Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp698017yba; Wed, 3 Apr 2019 17:57:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXPWFdThE9x9gYBW8hRihPlNqSwrgqA9R/VbAo6coTmmD3DLIqWFKY5ws5MV0DYldyUR/I X-Received: by 2002:a65:6546:: with SMTP id a6mr2821026pgw.5.1554339460163; Wed, 03 Apr 2019 17:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554339460; cv=none; d=google.com; s=arc-20160816; b=Zd9a1fjglExV2WrCQeDnsDFKxU6ZxBKkd0iNcONwRnN5Al3Gu8NMgxakenzYqlw/WX HlZlcCMxkPiGZ6ICBLuPlkoJCX8v7YN2TEU6DGlSDb6rLaccyvTw22u9QrZZ35zMG+aL FqI2vYri1eB1KfKk6iutwfKj9V57uVSCUbpao0lnWiTfnRPHu/jXDC+EHXsz7RV+4L1e wgimqzvWX0Q8xXfCImN8m6RtS/bi29Ch6kd/D6KBQQsxYhIxVqT1bKzpx8RfjpD0yEj4 EH1UcNTVEOtdj2omexcj9K2UIU17C4QQgwu4qGq7oF+g7sTLG5aN8ldLZzjliljYI/ws D5hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=seoAILuz7Cv84t/mKF94j2odiJmdprtCCeRrEcdf+54=; b=a1ofLQhCI3GuOFBOcvlVMKnzTjsahTZpXhZB3E6bULnBpriJFDzU4H90mVT44jqs2M 1IZKgLsEpp5UOOaL6w0Dt0pFqIGLX5hc/70YKjoZx7acg4+s6DDEZg8IeBeJwSeHgu5G XtebNUyMH2SwL3tXV/OabVPBUIVqQLb6KDuvw++6H0m8vXb9VIQ0jiNkmqMCq1jBe2Su CQecRaIJhHlN7WtOf4DqyBNkfYqXAwIlS2eiX/4YjOSpO5hUhAXOm+fgTEPuHhK4Yz7Y sgvqF+28lMAJsgVEj28Ppp4EOIr0pBPWoVp5qxKyJZJ0Pq3/5Q88ZRNRo9qEboWhTCuu 1b9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EYeahpNn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si14987183pfw.94.2019.04.03.17.57.22; Wed, 03 Apr 2019 17:57:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EYeahpNn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbfDDA4r (ORCPT + 99 others); Wed, 3 Apr 2019 20:56:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:54964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfDDA4q (ORCPT ); Wed, 3 Apr 2019 20:56:46 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A7D32133D; Thu, 4 Apr 2019 00:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554339405; bh=seoAILuz7Cv84t/mKF94j2odiJmdprtCCeRrEcdf+54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EYeahpNnvcaa4TUyHMtut0+8C6K7pSl2xXOrA0pKdmywE335pIRFooI9qWl8nKxsz 9ObiVRQSLAvNyN2PUD9M4Lllx3pgSvdxIoJx6U6dtVw8WtY6hKJ4/1KRSfiOqpL4wH FHVbLCDaMEsT57Ca0mstNRHXvrWty2CfdQCrHtfk= Date: Wed, 3 Apr 2019 20:56:44 -0400 From: Sasha Levin To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Catalin Marinas , Christophe Leroy , Christoph Hellwig , "David S. Miller" , Dennis Zhou , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Guo Ren , Guo Ren , Heiko Carstens , Juergen Gross , Mark Salter , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Paul Burton , Petr Mladek , Richard Weinberger , Rich Felker , Rob Herring , Rob Herring , Russell King , Stafford Horne , Tony Luck , Vineet Gupta , Yoshinori Sato , Andrew Morton , Linus Torvalds , iommu@lists.linux-foundation.org Subject: Re: [PATCH AUTOSEL 5.0 008/262] swiotlb: add checks for the return value of memblock_alloc*() Message-ID: <20190404005644.GI16241@sasha-vm> References: <20190327180158.10245-1-sashal@kernel.org> <20190327180158.10245-8-sashal@kernel.org> <20190328055520.GA14864@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190328055520.GA14864@rapoport-lnx> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 07:55:20AM +0200, Mike Rapoport wrote: >Hi, > >On Wed, Mar 27, 2019 at 01:57:43PM -0400, Sasha Levin wrote: >> From: Mike Rapoport >> >> [ Upstream commit a0bf842e89a3842162aa8514b9bf4611c86fee10 ] >> >> Add panic() calls if memblock_alloc() returns NULL. >> >> The panic() format duplicates the one used by memblock itself and in >> order to avoid explosion with long parameters list replace open coded >> allocation size calculations with a local variable. > >This patch is a part of a series that removes panic() calls from memblock >allocators rather than a fix. I've dropped it, thanks! -- Thanks, Sasha