Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp723141yba; Wed, 3 Apr 2019 18:34:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzt7TjlL+u3WVyLCPOfBeADwwzZIjStVN2Pzai3ylW7ZymmLO5ExF2Kbo3jdrOehRFPMdyS X-Received: by 2002:a63:f24f:: with SMTP id d15mr2904580pgk.410.1554341660564; Wed, 03 Apr 2019 18:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554341660; cv=none; d=google.com; s=arc-20160816; b=ndFqnfwezhJtnwlwssqtVfy5ggeBbs6kws7PhCqdIRXmpD8x/tBWeOwgJVqgVtimJu dPlcm7YN4EJL/bHgBoI0saC6aunapXt6c/Wa4kJ6BcueKh/Z3Axe+4J7qFsGbgswEQrn WR/y+DjmbDva/WaZ6xD7YG6BEhV/KNqwkEZY8QyjV6dAMgHw2rYUUjJmjzgOJwidV+Zy YUhBbqj11/ZOCylCvEuZQN6DByvg6rpoPyAH/L2oUycOiB9pXQNyzCdhFjLGbrkRaOsl SV/s3I6A8fAsPFQ7ye8c1z7OLxYlThDohl/eceZQn0DFlco5AvGVJr89OwjX8aUhgmL/ 9Xig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=+6l1fMVpfr9lMCDEoJZkFHnxUTcC5ba/0tTC5GoMs7k=; b=oik6fZWZ8lKZbZcpRrL3BzUUAwrrqsGHvNXAI73uVMwFbodLCSOYfVVdVZd1tT4hhX 8iEv9vxuxgmJ66Klql27FluXao234Nx91hrefC17FW/73/og9DXpYD1rcnR1heL0XKbe ngXUsQs37xdVVvzZT7HEjnCR2aLrLqRbloQvn3rwyvITnXu1dmKhomOB041NM448YJof NQZYGf/+GdSByfDY1N+RZOIcVrTY2LcH9xNgLApDi8+tlcViPLsVW1fF/YDLqbn+u6Tx Rt8XYmNopWHNHZ5LnLX/iAO+KyvfJKDjDpSp+ph5ZS99EVQtIfUvkYhcaJZ0SGlRv4VI Y/bA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si15087542pgi.417.2019.04.03.18.34.04; Wed, 03 Apr 2019 18:34:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbfDDBdY (ORCPT + 99 others); Wed, 3 Apr 2019 21:33:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:34454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfDDBdX (ORCPT ); Wed, 3 Apr 2019 21:33:23 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CBBA72133D; Thu, 4 Apr 2019 01:33:21 +0000 (UTC) Date: Wed, 3 Apr 2019 21:33:20 -0400 From: Steven Rostedt To: Matthew Garrett Cc: jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-api@vger.kernel.org, luto@kernel.org, Thomas Gleixner , Matthew Garrett , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH V32 19/27] x86/mmiotrace: Lock down the testmmiotrace module Message-ID: <20190403213320.403a0ea3@oasis.local.home> In-Reply-To: <20190404003249.14356-20-matthewgarrett@google.com> References: <20190404003249.14356-1-matthewgarrett@google.com> <20190404003249.14356-20-matthewgarrett@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Apr 2019 17:32:41 -0700 Matthew Garrett wrote: > From: David Howells > > The testmmiotrace module shouldn't be permitted when the kernel is locked > down as it can be used to arbitrarily read and write MMIO space. This is > a runtime check rather than buildtime in order to allow configurations > where the same kernel may be run in both locked down or permissive modes > depending on local policy. > > Suggested-by: Thomas Gleixner > Signed-off-by: David Howells Signed-off-by: Matthew Garrett > cc: Thomas Gleixner > cc: Steven Rostedt Acked-by: Steven Rostedt (VMware) -- Steve > cc: Ingo Molnar > cc: "H. Peter Anvin" > cc: x86@kernel.org > --- > arch/x86/mm/testmmiotrace.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/mm/testmmiotrace.c b/arch/x86/mm/testmmiotrace.c > index f6ae6830b341..9e8ad665f354 100644 > --- a/arch/x86/mm/testmmiotrace.c > +++ b/arch/x86/mm/testmmiotrace.c > @@ -115,6 +115,9 @@ static int __init init(void) > { > unsigned long size = (read_far) ? (8 << 20) : (16 << 10); > > + if (kernel_is_locked_down("MMIO trace testing", LOCKDOWN_INTEGRITY)) > + return -EPERM; > + > if (mmio_address == 0) { > pr_err("you have to use the module argument mmio_address.\n"); > pr_err("DO NOT LOAD THIS MODULE UNLESS YOU REALLY KNOW WHAT YOU ARE DOING!\n");