Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 4 Apr 2019 12:30:37 +0700
From:   Mark Brown <broonie@kernel.org>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Axel Lin <axel.lin@ingics.com>
Subject: Re: [PATCH AUTOSEL 5.0 209/262] regulator: mcp16502: Include
 linux/gpio/consumer.h to fix build error
Message-ID: <20190404053037.GK5748@sirena.org.uk>
References: <20190327180158.10245-1-sashal@kernel.org>
 <20190327180158.10245-209-sashal@kernel.org>
 <20190327193211.GC11404@sirena.org.uk>
 <20190404004608.GG16241@sasha-vm>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cEobB2knsyc5ebfU"
Content-Disposition: inline
In-Reply-To: <20190404004608.GG16241@sasha-vm>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--cEobB2knsyc5ebfU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 03, 2019 at 08:46:08PM -0400, Sasha Levin wrote:
> On Wed, Mar 27, 2019 at 07:32:11PM +0000, Mark Brown wrote:

> > > Fix below build error:
> > > drivers/regulator/mcp16502.c: In function =E2=80=98mcp16502_gpio_set_=
mode=E2=80=99:
> > > drivers/regulator/mcp16502.c:135:3: error: implicit declaration of fu=
nction =E2=80=98gpiod_set_value=E2=80=99; did you mean =E2=80=98gpio_set_va=
lue=E2=80=99? [-Werror=3Dimplicit-function-declaration]
> > >    gpiod_set_value(mcp->lpm, 0);

> > Does this error actually manifest in v5.0?

> I couldn't reproduce the error on f3c6a1a194317f^ so I assumed it
> requires a specialized config.

I suspect you will find this is a fix for a change that was only merged
in v5.1.

--cEobB2knsyc5ebfU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlyllnoACgkQJNaLcl1U
h9B+Ogf9HjUb/rIFl+hWvDW8mQGrXYPsVLeJ4ixhnUW4/JzJGy1l0HeZGn2sPgax
V6aQd9EOcc2zK8HxWU88QR3mtpyfjQwXRvKkiaCnmnW9EcogA9tKUJHwBhuibE74
47ZvfWs4BocMbXfb+DbglUHXK76zgmqrwdNaD02N80K2cPHbqUrvrzIaGi142ulY
QclkaOuOG7gfXvC4JHMmV2A90bQWMovrV+2JpZmY/1ESFjp0muGRD3lEmiOtnV7s
gcKMqtIwxkbST+99Ee7BxMc8QRkT7nOA6cfJOraabjnofS3L8/Q8DFut8DNQsuj+
9id9cke4JJ4QWCk42Z/zCbGDZM9xbw==
=Gykn
-----END PGP SIGNATURE-----

--cEobB2knsyc5ebfU--