Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp930831yba; Thu, 4 Apr 2019 00:22:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9VIVZFalj2F8G3IVx6btyNhXp+F+ivpijvC2+x4bQN7lW42fkUM/sM5vawOJHwvcIpWsi X-Received: by 2002:a17:902:407:: with SMTP id 7mr4857638ple.62.1554362551243; Thu, 04 Apr 2019 00:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554362551; cv=none; d=google.com; s=arc-20160816; b=zgDu364ZcO+gH4GEViPcY8Sq41aOMIWtjFc/U9AB9jkYD7VF75B3iGrsT481jzv1Bg 1OcPLkt6hM8G5ViKvq2etD4AwHAZX2y1/nbPO+KpGQwcZVoghRalgL8+ERALxgyM8XOU Gl4OKn4hox2kHFsaV4AsG7/JADW3paYNQQG3b5aq87APeu0/JmM75zqluh7mC1V09K9P uQu/KLoGihIrNk6nk0HDJiM557NLIWjNn9GT51BTIcKGjpWt8+Isq6Wj/oPnXn/SsfeQ vSmv7rBmr+b5S24G67fK9e9WOH8L4uw3/orshRwIc6mw9nm74W8VxHyi7xowY9ynhkrQ PAQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Vy0ji3F7prCNZU+iG4Syw1Bb8r9ZocB9hkHYB1v9qPA=; b=YHxTNjxWXFDSHQL1WyOnHcl24tdubv8ebCXWR84DEpHEiriFBGIIJLhjfJ06933ADP e/ElCmx6dgw5wCWdaS59/0fmJ5PGlrR2Om5yDt8oRmPtPYUvM2kSKCn8ijFYZdMonLXX dGTSmsevhXiBhx57fpfebP0bdjsLKB5oyhPwIsTwEbyNs7tDfeMdpNmWEgcZppr0UOYl fOxB383VdFHUve7WshKBsI2Mj7K4AmuRLQ9nRRzBXPCAY2qou1znYlUh6QpRgt8d9e7x cnwtF8WxuEMZancT5JanTYgyT9P8MgBQQrEuhmk1UYgmDN96upQoco/DNBxpcT+/4qXE zL4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si15923362pge.187.2019.04.04.00.22.15; Thu, 04 Apr 2019 00:22:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbfDDHUR (ORCPT + 99 others); Thu, 4 Apr 2019 03:20:17 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:46323 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726058AbfDDHUQ (ORCPT ); Thu, 4 Apr 2019 03:20:16 -0400 X-IronPort-AV: E=Sophos;i="5.60,306,1549900800"; d="scan'208";a="58457312" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 04 Apr 2019 15:20:12 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id C60684CD7EE6; Thu, 4 Apr 2019 15:20:10 +0800 (CST) Received: from localhost.localdomain (10.167.225.56) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Apr 2019 15:20:18 +0800 Date: Thu, 4 Apr 2019 15:20:07 +0800 From: Chao Fan To: Dave Young CC: "bhe@redhat.com" , Junichi Nomura , Borislav Petkov , "kasong@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190404072007.GL1555@localhost.localdomain> References: <20190403072141.GE1555@localhost.localdomain> <20190403080846.GB2579@dhcp-128-65.nay.redhat.com> <20190403082305.GG1555@localhost.localdomain> <20190403090210.GH1555@localhost.localdomain> <20190404025234.GA12658@dhcp-128-65.nay.redhat.com> <20190404030037.GT7627@MiWiFi-R3L-srv> <20190404031030.GU7627@MiWiFi-R3L-srv> <20190404032238.GA16267@dhcp-128-65.nay.redhat.com> <20190404064130.GA5530@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190404064130.GA5530@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: C60684CD7EE6.ACFD0 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2019 at 02:41:30PM +0800, Dave Young wrote: >On 04/04/19 at 11:22am, Dave Young wrote: >> On 04/04/19 at 11:10am, Baoquan He wrote: >> > On 04/04/19 at 11:00am, Baoquan He wrote: >> > > On 04/04/19 at 10:52am, Dave Young wrote: >> > > > On 04/04/19 at 01:23am, Junichi Nomura wrote: >> > + /* Save RSDP address for later use. */ >> > + boot_params->acpi_rsdp_addr = get_rsdp_addr(); >> > + >> > + error("Hang kernel for kexec debugging"); >> > >> > Sorry, here I means calling error() to hang kernel after calling >> > get_rsdp_addr(). >> >> Thanks, it did not hang, it always reset to firmware/grub boot menu. >> I'm pretty sure now the bug exists in get_rsdp_addr(). > >static acpi_physical_address kexec_get_rsdp_addr(void) >{ >... > /* Get systab from boot params. */ > systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); > if (!systab) > error("EFI system table not found in kexec boot_params."); > >... > -> add error("hang me") here will have a hang >... > return __efi_get_rsdp_addr((unsigned long)esd->tables, > systab->nr_tables, true); > I have an idea, but not sure whether is a problem. In code of Nomura: #if defined(CONFIG_EFI) && defined(CONFIG_X86_64) [...] if (strncmp(sig, EFI64_LOADER_SIGNATURE, 4)) { debug_putstr("Wrong kexec EFI loader signature.\n"); return 0; } /* Get systab from boot params. */ systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); [...] #endif After review agian, I wonder what will happen if 32bit-efi boot 64bit OS. Ever meet a problem: https://lkml.org/lkml/2019/2/8/845 It's a efi32 bootloader to boot a 64bit OS, then a problem happened. Thanks, Chao Fan >But add error("hang me") in __efi_get_rsdp_addr it did not hang. > >It seems reference the systab pointer cause a system reset. > >A question is does the identity mapping covered the memory address of >systab? > >In my case it is 0xdad9ef18 > >If the memory is mapped on demand, then there will be problems, it >should cover setup_data and efi table space. > >Thanks >Dave > > >