Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp967178yba; Thu, 4 Apr 2019 01:18:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqykXGBXULeWYKNNeqY6o5NFIROlHkVhahO0AdMCvso09PeAbx+I5S+W63/B7FTIvrePc48n X-Received: by 2002:a17:902:bd92:: with SMTP id q18mr5014700pls.136.1554365919606; Thu, 04 Apr 2019 01:18:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554365919; cv=none; d=google.com; s=arc-20160816; b=rlS01GjR0D9Ppkk1YDJ8gVt01Te07/YqRwPF326Co5uftJzui2d6k6hb38zvlmeGws MCJ0rP16D620Ev8KGK/9Aunyz5ijV/Yh0ULLjW57XZ8273dPxrYYJWgGg2LKhXWof5gr DPTk2iz9q9gLWjdTnOUugWlym0OvnKKnrZ6MEIa6EfrIQ5IJn/jUjIoBTZwhgLXnqdQP noxbHVU19gswuuZ2uCQ01U7tPyxIkS5ng5BEhsho38/Y+RA9PVLNuNVtDSi0AeaPugtP tIyJB4Ak0eb43h6tl2nz4xV7Xk7OOf98KmqQrqE7J9v9y4FrxGMAV2D5eJJcai12+qzs ZEwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=4IjJUDwwQm4taL0qsOOF+oE9ce3AozsivfzJGbmmA7k=; b=Zd87/GfmVUNdDMz1E36O/7Dhbe7uGzg4e6i/BdB4TyEJcFE0TufzsqCxDrGHOewyUp Yhbdd481c6lqJ8P3MCkCFdzNxVQ9JGoVZuOVKHcIZzs+/XdAqgteIwcsjzBQv6JatPFo 8pL3RM8pSDIoUmgniZnkrhzd2Y24OqGDot9fwA9J7dxROMPDsg+hDEL5EUQtm2UBBedT 5tcgxo/kth4ktNss3ZyNplvTKfTD+wJldrAB+EOjLy8XdWU4O/Kl5sVgUqxE3y/C05xX dUUm+aSqdjrkszt4/1WJeWj/N04NJMJTuhjRXJxz1LafN5pPUJ4fLWILyjTwSzHoZrT7 l9pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BaVal56j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si14668841plq.400.2019.04.04.01.18.24; Thu, 04 Apr 2019 01:18:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BaVal56j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728802AbfDDIRT (ORCPT + 99 others); Thu, 4 Apr 2019 04:17:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:51276 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728744AbfDDIRP (ORCPT ); Thu, 4 Apr 2019 04:17:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=4IjJUDwwQm4taL0qsOOF+oE9ce3AozsivfzJGbmmA7k=; b=BaVal56jnNSx 4VRU1SWLkCkPbXHxQffLzBRGHb/6IzzoE/+9OzO46X5PunhyaYnwi4kKbOQ8Y6uEEIp3qcjTLGb49 6VSe21pYVFirijXuDcQH1ZgxWGegUd1L3vyvgFrHGqu/HccIclOFp96tLu7ow8sQDd5LC9gJw7CwF RA8WM=; Received: from [147.50.13.10] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hBxYY-000536-Ef; Thu, 04 Apr 2019 08:17:06 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 5AB33441D3D; Thu, 4 Apr 2019 15:17:03 +0700 (+07) From: Mark Brown To: Sugar Zhang Cc: Mark Brown , heiko@sntech.de, broonie@kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: rockchip: pdm: fix regmap_ops hang issue" to the asoc tree In-Reply-To: <1554298856-59028-2-git-send-email-sugar.zhang@rock-chips.com> X-Patchwork-Hint: ignore Message-Id: <20190404081703.5AB33441D3D@finisterre.ee.mobilebroadband> Date: Thu, 4 Apr 2019 15:17:03 +0700 (+07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rockchip: pdm: fix regmap_ops hang issue has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From c85064435fe7a216ec0f0238ef2b8f7cd850a450 Mon Sep 17 00:00:00 2001 From: Sugar Zhang Date: Wed, 3 Apr 2019 21:40:45 +0800 Subject: [PATCH] ASoC: rockchip: pdm: fix regmap_ops hang issue This is because set_fmt ops maybe called when PD is off, and in such case, regmap_ops will lead system hang. enale PD before doing regmap_ops. Signed-off-by: Sugar Zhang Signed-off-by: Mark Brown --- sound/soc/rockchip/rockchip_pdm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index 400e29edb1c9..8a2e3bbce3a1 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -208,7 +208,9 @@ static int rockchip_pdm_set_fmt(struct snd_soc_dai *cpu_dai, return -EINVAL; } + pm_runtime_get_sync(cpu_dai->dev); regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, mask, val); + pm_runtime_put(cpu_dai->dev); return 0; } -- 2.20.1