Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 75AEC61D8B
Subject: Re: [PATCH] remoteproc: silence an uninitialized variable warning
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Andy Gross <andy.gross@linaro.org>
Cc:     David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20190404084204.GA20193@kadam>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <a08db945-44d3-ff99-7a89-75367f314855@codeaurora.org>
Date:   Thu, 4 Apr 2019 14:47:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190404084204.GA20193@kadam>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/4/2019 2:12 PM, Dan Carpenter wrote:
> Smatch complains that "ret" might be uninitialized.  I can see why it
> generates the warning, but I don't know if it's actually possible.
> Anyway initializing "ret" here is harmless.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>   drivers/soc/qcom/mdt_loader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
> index 1c488024c698..fc58d660692f 100644
> --- a/drivers/soc/qcom/mdt_loader.c
> +++ b/drivers/soc/qcom/mdt_loader.c
> @@ -188,7 +188,7 @@ static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,
>   
>   	if (reloc_base)
>   		*reloc_base = mem_reloc;
> -
> +	ret = 0;


You are overriding the value here, better keep it at the start.
Thanks,
Mukesh

>   out:
>   	kfree(fw_name);
>