Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1012390yba; Thu, 4 Apr 2019 02:24:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWEyyNilksNQTMHQZL3YZCFDloTxA/ju+u4/4n0bS72Kxv1b277AW6U/mV1r2Nv5v+UYHc X-Received: by 2002:a63:5a20:: with SMTP id o32mr4617268pgb.225.1554369865106; Thu, 04 Apr 2019 02:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554369865; cv=none; d=google.com; s=arc-20160816; b=ujCuSPmX1aSQ8OWgKK6hxXMnTz/iu5/Covrmt2BhqNHCiTVjKDB2uZ/2Hpf2fADqSo 3uXNWNu8SXOs6msT/wUOgEjH4QHPOiHtBPD+hb/tsN3LkeR+v47FEijyz5W6rxUi2E8n QbyZf7/thzG7OCgX0OK3PNZfdc80iY5SROIpk8IhlyMk7i93/zB8A/6ivHInLFNVVqwp QmLN/pZxPZgghA7zIV+m4kW1mAlFlcFYoNVymvDHToPelg52f6rcImt6QZJJ8ixhahJo 9s8V/kHTCFIXweZj4oOPrYh4/iCt0av8f3QXtaDLRd6TUR2BdG22BNTwTKglKJ+YbEff LedA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ccaYWAy6+QjGh2d26kzEc1V3tkR0YLZLvERC+lUM0Yo=; b=wS9t8OvhMpDPbOv33ak3DDBLggpSUIKYti0nkaBX+NrTyqPh93bf3RK+bHVAHzPFNX OneVyl3zv/pOEbSblmEWrloV4BCoIjSQixVb3RpWVKAtCDw4a/MA5Qr6sBRepkwF7ADg 3JNlOiOIcx+lQAkLZucvY4UD9TWE4NiR99fQxyGvOLZT6DUmfzqTt+LvAUmCDa4sWHe9 kbThlb5C1UvXstgEpcseqPjdDXOsYCTa9Ud6bpAVuCF71/niEcF7Q5OrUxD12RJtfBUl Qu8EH3EvLNO23kp2KFhEtocBRtoezqanqd2cZPW+SMOkgVUtKCJezQZJdufGv8E9eeFe a7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qbhfu2kC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si15152722pgw.70.2019.04.04.02.24.09; Thu, 04 Apr 2019 02:24:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qbhfu2kC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387877AbfDDJPY (ORCPT + 99 others); Thu, 4 Apr 2019 05:15:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:56306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387467AbfDDJPW (ORCPT ); Thu, 4 Apr 2019 05:15:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1016F2075E; Thu, 4 Apr 2019 09:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554369321; bh=bJeSUAmAfqUFVULoecThs62W5RENmoqSzHCULfskGqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qbhfu2kCEOl5Lw0gOB2AvDU2ZCwSyBBk8ZhfFjUL4W9DGeYOuOURp6tcsJWqRa+wP Win0qGWcSCIgp47oxIyrfqbxXW7AMVeYjTN0xmmbaRLfRcIjf0isdpnjaSumvVemNO mlsoKWRFm3e/lsQcRmmyJY2H17mO4bm5NcaT3KG8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Roese , Mark Brown , Sankalp Negi , Chuanhong Guo , John Crispin , NeilBrown , Sasha Levin Subject: [PATCH 5.0 171/246] staging: spi: mt7621: Add return code check on device_reset() Date: Thu, 4 Apr 2019 10:47:51 +0200 Message-Id: <20190404084625.163463927@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190404084619.236418459@linuxfoundation.org> References: <20190404084619.236418459@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 46c337872f34bc6387b0c29a4964f562c70139e3 ] This patch adds a return code check on device_reset() and removes the compile warning. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/mt7621-spi/spi-mt7621.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c index 513b6e79b985..e1f50efd0922 100644 --- a/drivers/staging/mt7621-spi/spi-mt7621.c +++ b/drivers/staging/mt7621-spi/spi-mt7621.c @@ -330,6 +330,7 @@ static int mt7621_spi_probe(struct platform_device *pdev) int status = 0; struct clk *clk; struct mt7621_spi_ops *ops; + int ret; match = of_match_device(mt7621_spi_match, &pdev->dev); if (!match) @@ -377,7 +378,11 @@ static int mt7621_spi_probe(struct platform_device *pdev) rs->pending_write = 0; dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq); - device_reset(&pdev->dev); + ret = device_reset(&pdev->dev); + if (ret) { + dev_err(&pdev->dev, "SPI reset failed!\n"); + return ret; + } mt7621_spi_reset(rs); -- 2.19.1