Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1034975yba; Thu, 4 Apr 2019 02:57:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTfmdtcTLWXwY5V5F4J8cHeG53fAsyJAiJfEh2T3EKrXP2Xw5HsPMpYIbwCRcABI6W5o3j X-Received: by 2002:a63:5f05:: with SMTP id t5mr4783427pgb.176.1554371822312; Thu, 04 Apr 2019 02:57:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554371822; cv=none; d=google.com; s=arc-20160816; b=e4XYpjJKH9etlD81xSa0pbopQc8hB7NThfQEHeeoLCHbi25qfrxET9zHxx3cJX1xIb wNBaZnl8jC9ITmmG9UbLC8QXYxdP+iXHa58pYJ8OKHWQJUnJp9aoNMS3tTNe7z/pQbf8 42bpR/W6q5+R47v0ER11+SsQKD9OcMuqZ8TSKr5cZYYnbXyIuoKOthcRmNe1D0wibj1x 8E0VBAQad4Y5r9GBFFY4MsO10P9Vre+lBPBuzPq3xGtggpul1Ud9NGAXDfK1ZIOg8jE+ uCq1ro573ml1q/O1vAA0fxmwMF0XOGmPcZmZdl+xE0IBtS8tH43xsTTbxxrJny+d/6pY eaQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=f3++McMZBbjmJdO5chqeA/2PhTXU1mHTNwrn9qeXMHk=; b=IOeMV2v1/kkXAH4I9bNX5EGT07QtCIUeZZCoqmeXuOf0JYg1tq0tMTOir9cNH7MPlb xrCPgRX8bhDRFPOCrU03Yoil2a6EvW6OcDfTMUaKBD6YQOB3Z5jYRYnF4xUndmP4+FyB A1J1xnIelOhsk0Y/QtUZScozzcbNhgpQsDp3HRRGaLxk/1LKRoKhLo4l3tygv4qXqwVd mihGsPT5WQth04bYrbjZATQ1wNQIGtKLCy68qSE8KLVvFHPdU9J8lV7jDy2gtXP7tYG4 fsONvfErp59VxsJ3hw/u6boUIW1L+dOC4QhoOfzKWYLISMMRt/RSEgbbKJkGUy9GVdmC 82ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KoD/htVa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si16163775pgz.259.2019.04.04.02.56.47; Thu, 04 Apr 2019 02:57:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KoD/htVa"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729242AbfDDIvB (ORCPT + 99 others); Thu, 4 Apr 2019 04:51:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:52438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728842AbfDDIu7 (ORCPT ); Thu, 4 Apr 2019 04:50:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1391221738; Thu, 4 Apr 2019 08:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554367858; bh=WwSLadT3uDVx3R72xrGenD5lgJe1JPd7tHH+0CI6o5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KoD/htVaOWYwOzMkYN03DHYlznRly69zSBHDEqTY5ijyCEXOCWmF4/E5Hc+Z0oW0b eZckqC7xABp8rlVB+cBieHXHkHkpzZg5hmRbMjeyHVluQHKfF+N/1KANrWmNQSyAE5 TBzbuGcyx/yapm7Cf/qdXytpsrpjQROIuO6DBJOo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luc Van Oostenryck , Jens Axboe , Thomas Gleixner , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.9 13/91] include/linux/relay.h: fix percpu annotation in struct rchan Date: Thu, 4 Apr 2019 10:46:57 +0200 Message-Id: <20190404084536.196283003@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190404084535.450029272@linuxfoundation.org> References: <20190404084535.450029272@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 62461ac2e5b6520b6d65fc6d7d7b4b8df4b848d8 ] The percpu member of this structure is declared as: struct ... ** __percpu member; So its type is: __percpu pointer to pointer to struct ... But looking at how it's used, its type should be: pointer to __percpu pointer to struct ... and it should thus be declared as: struct ... * __percpu *member; So fix the placement of '__percpu' in the definition of this structures. This silents a few Sparse's warnings like: warning: incorrect type in initializer (different address spaces) expected void const [noderef] *__vpp_verify got struct sched_domain ** Link: http://lkml.kernel.org/r/20190118144902.79065-1-luc.vanoostenryck@gmail.com Fixes: 017c59c042d01 ("relay: Use per CPU constructs for the relay channel buffer pointers") Signed-off-by: Luc Van Oostenryck Cc: Jens Axboe Cc: Thomas Gleixner Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- include/linux/relay.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/relay.h b/include/linux/relay.h index 68c1448e56bb..2560f8706408 100644 --- a/include/linux/relay.h +++ b/include/linux/relay.h @@ -65,7 +65,7 @@ struct rchan struct kref kref; /* channel refcount */ void *private_data; /* for user-defined data */ size_t last_toobig; /* tried to log event > subbuf size */ - struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */ + struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */ int is_global; /* One global buffer ? */ struct list_head list; /* for channel list */ struct dentry *parent; /* parent dentry passed to open */ -- 2.19.1