Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1050690yba; Thu, 4 Apr 2019 03:16:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRKpWexhgmkX0txDqkBQOrtHw2opJxKMzSVGQICgM3nJPOiVFxCGo9mQWRUiGopLxQBnFu X-Received: by 2002:a63:7154:: with SMTP id b20mr4996076pgn.359.1554372959921; Thu, 04 Apr 2019 03:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554372959; cv=none; d=google.com; s=arc-20160816; b=yqD4gMSGjU+d/8ZUGQ2Z+4SrvNs2tAQ/qZLliyxERRcYtDxSaJqasSvvZqlPRogiII vmh9pkHi4LbXkn7wygMzm23wGBh/dgdYKlmisDt6H9qOkXzEPHddmWpYYxQK/cDbK6yy G7AWbX6NAOOUkHeBbCMaWYaPgcElfbLhlyqnB3oZV4YT3wa6iqrVJtYtRYTlUIzJ3Q1g /RBDBDHVBA7zH7ahhsBUEBdkCoD8Nv3rVJwzNTb3ATuETGSC/2TcwZ4NRozMbnF1JMwT Gb/RZAaF/qZBVtzOthvQSYkPkxw9gFCU4SFH36n6Pwax/IyYfshzZOnQ/KavAVOI68Fa VjQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=sZAyQa0UUim8Rx4Q2eJe8SiUVcrkMF3uhQDVUPd7MRM=; b=fwbxqh0hJKcMFp0464Hd3W/KIhrPeK/knkxJdwyfTXmesskESX2gsfITKA09tpiF9j x9xV1pdgirAXnxEdARiZg7pC1rT1mG7qw7Y6rkp1huYEVW/RrQd6u3db451Q+JcgwdIy x4g1na10gujMJNELjLZPoFf9+a1Y6VX7XX3D3WIU/HCKXiVNiLN9T60CpZcRZ+1z8MsS Wixh3kTty5vxKZvQ3s73Yfcbg9wUWZsnYL4616MXlY4IMESPzZzJFFsFGYsp8p2DzfEH 7gHBBe2wf0yicA8LW0+QvMzVDLG7tk4PUkDtjkzjiO5mE8cx7xS1AFWwNu5xXOIbev5t 0r0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f0NajSm7; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jq+fGbZa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a14si16140009pgd.176.2019.04.04.03.15.44; Thu, 04 Apr 2019 03:15:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f0NajSm7; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jq+fGbZa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729100AbfDDKNl (ORCPT + 99 others); Thu, 4 Apr 2019 06:13:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37944 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfDDKNl (ORCPT ); Thu, 4 Apr 2019 06:13:41 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 09A9461836; Thu, 4 Apr 2019 10:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554372820; bh=J+Ymf1zOe05e/G0Pq7gWzdmC0ObjXqE6ys1W0FRBdx0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=f0NajSm77o0m89Ns8gVAVgCDDDHxbh17fLVjzmR2XylNEH5923FihbC/tGweHBQ23 AdqfhFwGiCrTtCwaDRsTYdrbW57tT5J/tkPJ7/OzgCW4S3wkH7ymLKIEMnt8/yyynq PFu5XqdwMlwr0uR9uO9wYSsqrUi/eziN9uu2j4Ew= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5C01161A41; Thu, 4 Apr 2019 10:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554372817; bh=J+Ymf1zOe05e/G0Pq7gWzdmC0ObjXqE6ys1W0FRBdx0=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Jq+fGbZa5xx806/nzl6cC/IZWT7ZzfCo9M3iuOVfMWID8Qvke3455JBGklWMuo0oQ s2gw7/4cnKAvw3FhtDoYbfjd80dBDW7pQtTcLrnR9Ay31tSZIxBkJ0BQTVJEU4EMz+ M+AbUlHpuPDoZ5S72WNNl2onYev0vbuptAGyv/L0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5C01161A41 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] brcmfmac: fix missing checks for kmemdup From: Kalle Valo In-Reply-To: <20190315170433.3845-1-kjlu@umn.edu> References: <20190315170433.3845-1-kjlu@umn.edu> To: Kangjie Lu Cc: kjlu@umn.edu, pakki001@umn.edu, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Stefan Wahren , Chung-Hsien Hsu , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190404101340.09A9461836@smtp.codeaurora.org> Date: Thu, 4 Apr 2019 10:13:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kangjie Lu wrote: > In case kmemdup fails, the fix sets conn_info->req_ie_len and > conn_info->resp_ie_len to zero to avoid buffer overflows. > > Signed-off-by: Kangjie Lu > Acked-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. 46953f97224d brcmfmac: fix missing checks for kmemdup -- https://patchwork.kernel.org/patch/10855341/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches