Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1050758yba; Thu, 4 Apr 2019 03:16:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqx18YUgOXb11zVQaXGUDxyQ4+SsKvzpxmqHA1zGwlo4N/xDoIuejE5AqEgAmuTniBsnhVLZ X-Received: by 2002:a17:902:8e82:: with SMTP id bg2mr5547083plb.217.1554372964314; Thu, 04 Apr 2019 03:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554372964; cv=none; d=google.com; s=arc-20160816; b=WujQN3q9gjzjaJJKcZR61zaBMDY3SRM+Atc/ynxnVkui8JFaOjlb+FUH3PrSHGSIHU f/U1tdhcFPFc6S/8sp8YpHWUwywdbVbsEpFxQUI+5QFCoh49+a+PWvL0E6dYqldzCZnL X/G4lN2J54JUEt9EIXZkSor2IudOupTHGsmoxwHRfD8ixs8N5RqyyiOCpoNjDVIgV5fn fuFILpz6DkKEGpwAKWfRrTsYdOYC4SIIFTVjgHeqzeFTAD8N2IaCpWqzoREdVaLGAQDt J+TMB/reX3w8aDOxXvRc3neHnUXaP+ZV7HzobP0jFgGM8rovpD/dJCubv8RZJlNj2Y0m AlZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=8b2OMPg/NTLWyZaxpiGwU+c3DOS2bCwotOuM60A3uj4=; b=sKzhz+h5cCWeB9jaXhMISPIELOQ48YMOodAqSTFkcBS/mw143Xow5q2NqkMgo6QCK1 EC06FcaFdlVBQBobPuPfAghB0ya3+c7EmW8GMyAd2mm7yfTz5A9XZtDBpUEz7i2/YIW4 4WTjijMt6G/ON6f155LZgBiY5fp3voSz8Z3wJ08JAlUMfTT4x1ZDjJ72/Bb/VaV3PpQn CGtUSls4iPDgkzVw1eamS/yHw/TOFbfUfOuiKFTFfxxh8gIbTiAIQs9wzRuv4/paYdVC 2zTW5c2pTSXxifEF27U83HwsQLK8vWgzXAPH7/M1KVmQXY60mDlS4fIx6ITDC77LvByz pStw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=PBBZs1I9; dkim=pass header.i=@codeaurora.org header.s=default header.b=grcKCLoZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si5366442pge.547.2019.04.04.03.15.49; Thu, 04 Apr 2019 03:16:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=PBBZs1I9; dkim=pass header.i=@codeaurora.org header.s=default header.b=grcKCLoZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729220AbfDDKPG (ORCPT + 99 others); Thu, 4 Apr 2019 06:15:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38888 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728925AbfDDKPG (ORCPT ); Thu, 4 Apr 2019 06:15:06 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 28B0E61B5F; Thu, 4 Apr 2019 10:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554372905; bh=Aic9mjr4Fu0bz73F3kwYVnpIctwrUwFjBAn9AkLBb04=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=PBBZs1I9bhzRFzFp6wX/RVv0gYisjsu9J9BPp7xm1x6bA0rU8ss8dDVOhFWMy71NR Kq8P4y1vnWU9cXm5wqhnKJWJSC35ZRvAzbYoF7AbaOwGKHscd8OxEPaxuIkc84Zdcs SmSt1teRuDHfW6Ff4Coz22ouqojiTJjkYcQvDTrk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DF0F461B51; Thu, 4 Apr 2019 10:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554372903; bh=Aic9mjr4Fu0bz73F3kwYVnpIctwrUwFjBAn9AkLBb04=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=grcKCLoZzl1jKVTk3XSDBZmJ0pUFli9rJ24NRgrZPnk8nuXm3VJbYdp82S+1piVGM pU/N9h2MTqTzIZlCh2NIszGKEIOMwTS5Zx20CQF4kiIJoNoGPkC+CU9PLuWfXuUA6P NYHzLmDwtOwLZREZ5VY057GwEysbSrmxaYXMUmVY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DF0F461B51 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] iwlegacy: remove redundant assignment to *res From: Kalle Valo In-Reply-To: <20190330201422.8024-1-colin.king@canonical.com> References: <20190330201422.8024-1-colin.king@canonical.com> To: Colin King Cc: Stanislaw Gruszka , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190404101505.28B0E61B5F@smtp.codeaurora.org> Date: Thu, 4 Apr 2019 10:15:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Currently 1 is being assigned to *res and then it is immediately > updated with the computed result. The first assignment is > redundant and can be removed. > > Signed-off-by: Colin Ian King > Reviewed-by: Mukesh Ojha Patch applied to wireless-drivers-next.git, thanks. 6603c5844a44 iwlegacy: remove redundant assignment to *res -- https://patchwork.kernel.org/patch/10878565/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches