Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nvmem: core: fix read buffer in place
To:     Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc:     linux-kernel@vger.kernel.org, niklas.cassel@linaro.org
References: <20190320193242.20159-1-jorge.ramirez-ortiz@linaro.org>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <cf4964e6-a544-c31a-c739-a9776e36da0f@linaro.org>
Date:   Thu, 4 Apr 2019 12:01:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190320193242.20159-1-jorge.ramirez-ortiz@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 20/03/2019 19:32, Jorge Ramirez-Ortiz wrote:
> When the bit_offset in the cell is zero, the pointer to the msb will
> not be properly initialized (ie, will still be pointing to the first
> byte in the buffer).
> 
> This being the case, if there are bits to clear in the msb, those will
> be left untouched while the mask will incorrectly clear bit positions
> on the first byte.
> 
> This commit also makes sure that any byte unused in the cell is
> cleared.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Applied Thanks,
Srini