Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 218BE6044E
Subject: Re: [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI
To:     Yue Haibing <yuehaibing@huawei.com>,
        andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
        bgolaszewski@baylibre.com
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
References: <20190404103925.25652-1-yuehaibing@huawei.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <3b6d3845-90df-3898-76b2-646d7c4eb50a@codeaurora.org>
Date:   Thu, 4 Apr 2019 17:10:23 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190404103925.25652-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/4/2019 4:09 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> When building CONFIG_ACPI is not set
> gcc warn this:
>
> drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name:
> drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device
>     put_device(&adev->dev);
>                     ^
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh
> ---
>   drivers/gpio/gpio-merrifield.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c
> index 2383dc7..78ac32f 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -379,17 +379,18 @@ static void mrfld_irq_init_hw(struct mrfld_gpio *priv)
>   
>   static const char *mrfld_gpio_get_pinctrl_dev_name(struct mrfld_gpio *priv)
>   {
> -	struct acpi_device *adev;
>   	const char *name;
> +#ifdef CONFIG_ACPI
> +	struct acpi_device *adev;
>   
>   	adev = acpi_dev_get_first_match_dev("INTC1002", NULL, -1);
>   	if (adev) {
>   		name = devm_kstrdup(priv->dev, acpi_dev_name(adev), GFP_KERNEL);
>   		put_device(&adev->dev);
> -	} else {
> -		name = "pinctrl-merrifield";
>   	}
> -
> +#else
> +	name = "pinctrl-merrifield";
> +#endif
>   	return name;
>   }
>