Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1153053yba; Thu, 4 Apr 2019 05:25:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwEhPkQ4Nmr9txwy8ZYpQwIo/eU3TziDKOJpaD5pEgdcvK2fxhalsVxtOC19+deHEjn7zpC X-Received: by 2002:a17:902:501:: with SMTP id 1mr5974253plf.72.1554380729716; Thu, 04 Apr 2019 05:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554380729; cv=none; d=google.com; s=arc-20160816; b=dQKh+fBh628x5TeDWxEDfpYfqtYAEHVsIXTme87CgO14eIRMFNNlI9bYOi7IPCFkA1 9c4hizU4fJnOOEmpagehj49DeTpQ88ifJSCLo+td8vpxkHvqlfhZsNKubxHuyQeGSpJp 5Wdrw3gPU/1jE2qkoJyfMeFdm/9o2oMuQROoZkbEzW7YzCG4exR+ixjGAieo9gpXnPfx 9u8UdmPtV6JIpx4QJAdjR1IyOPyMCQRck3hT4P7PYpCOHmw3+V2ZGBSRRldujY0ve1K5 AospYNx2l/aEZWa2z7xQzpxqZa7VluVTXap/JNBs49euYd5JdbdfTHIL0unbztTyyN7/ DatA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=uZTXvTLGkLDqy3CIH4NGp3FIe5g/vVod/lzgCt4u3cU=; b=R64Od3bIzofZt1o4IPwfuu45ex4bDPJDNbjSoWpr2B3HVGgIUCq7cPumjIb8ILEy4j uJQs8rBW/BfJVhuZZelOFBG2mqtQ9MfQP06Fu/jtTtGw8y5iCyZc7y14/qD6riHYRHfI /ZdGGtbZXJEXyBVnmG9uBffJ1hckT325crDOaQxXJNYosUPuM1e2hBUkVJoDj+1/mEXb 7Cbd6brzLpGgZDOKIbAlz3VZ0489I96wLZs7MDAQYH3sCrEw+kK04fEZ0+HVZMVQ68HF ZNKRwAl37uFeGD/lUIndAwHjDqr1CukrSku7pSe2o4HFv14XfVt1QRsPxI1TKxfNxTRt ZmjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NoHbjUCQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e20si16053364pfi.237.2019.04.04.05.25.14; Thu, 04 Apr 2019 05:25:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=NoHbjUCQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729839AbfDDMY3 (ORCPT + 99 others); Thu, 4 Apr 2019 08:24:29 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38804 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727562AbfDDMY2 (ORCPT ); Thu, 4 Apr 2019 08:24:28 -0400 Received: from zn.tnic (p200300EC2F148A00329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f14:8a00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1F72F1EC064E; Thu, 4 Apr 2019 14:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1554380667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uZTXvTLGkLDqy3CIH4NGp3FIe5g/vVod/lzgCt4u3cU=; b=NoHbjUCQbyNtqSuNHrljUOdUzT68sCf6L7MJQS5vd1Wv1KBzSY8FR0Q1Ws3v2jFskbzDdi 7G849nGI0/pNc2Mh6ijhDP2AGisy1gLgsRcRp1F+CtvCNCzDr8cIMZm0yCCSPUOXUsEqtX OHLsGgwFNXWo4eOZ26cPzhxXaWAIIB4= Date: Thu, 4 Apr 2019 14:24:25 +0200 From: Borislav Petkov To: Dave Young Cc: Junichi Nomura , "bhe@redhat.com" , "fanc.fnst@cn.fujitsu.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "kasong@redhat.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190404122425.GC22539@zn.tnic> References: <20190325123229.GL12016@zn.tnic> <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190402102529.GA21698@jeru.linux.bs1.fc.nec.co.jp> <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190404073233.GC5708@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2019 at 03:32:33PM +0800, Dave Young wrote: > BTW, it would be good to start a new thread when you send V4 :) Yes please. > > + /* Get systab from boot params. */ > > + systab = (efi_system_table_64_t *) (ei->efi_systab | ((__u64)ei->efi_systab_hi << 32)); > > + if (!systab) > > + error("EFI system table not found in kexec boot_params."); > > Instead of hang the system, return 0 should be better Can the kexec kernel even function if we fail here? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.