Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190404081620.zx5rt2j2rjvdcglt@yubo-2> <af74fc26-2790-d83b-5320-bd4581e00585@gmail.com>
In-Reply-To: <af74fc26-2790-d83b-5320-bd4581e00585@gmail.com>
From:   Bo YU <tsu.yubo@gmail.com>
Date:   Thu, 4 Apr 2019 20:24:13 +0800
Message-ID: <CAKq8=3LNN1-KQ_33tRa8niQWT8YjD_0F_1qgzwPi35asaTQbBg@mail.gmail.com>
Subject: Re: [PATCH] bpf:sample: fix field 'lock' has incomplete type in hbm.h
To:     Eric Dumazet <eric.dumazet@gmail.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>, songliubraving@fb.com,
        Netdev <netdev@vger.kernel.org>, Yonghong Song <yhs@fb.com>,
        open list <linux-kernel@vger.kernel.org>, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 4, 2019 at 4:30 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 04/04/2019 01:16 AM, Bo YU wrote:
> > When compiling sample/bpf:
> >
> > samples/bpf/hbm.h:12:23: error: field =E2=80=98lock=E2=80=99 has incomp=
lete type
> >  struct bpf_spin_lock lock;
> >
> > Fixes: 187d0738ff35(bpf: Sample HBM BPF program to limit egress bw)
> > Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> > ---
>
> This patch makes absolutely no sense.
>
> Please carefully read samples/bpf/README.rst
Ok, got it.
Thanks,
>
>