Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1204205yba; Thu, 4 Apr 2019 06:21:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAYRmPuIftZfI+O305ItEWbWwILTRWQPS6za2uyH3PkciZBdjQPhjhHDlOtk9CzXmcOcna X-Received: by 2002:a17:902:248:: with SMTP id 66mr6180097plc.286.1554384092293; Thu, 04 Apr 2019 06:21:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554384092; cv=none; d=google.com; s=arc-20160816; b=YRixkoMXhYlBpDS+/ChZvxHZcDaF/5smzHN0VAKaFjTonAdVm960Rno5ZhdHxg2jfq Zdau7uu3UkbtYcpzPBlk//X0/VNVGbnIAHGA+XRo2kFiucGgD9q9lPqUzoqQvg+uJEl4 psIaWAmVHe6az8LJhc+ACfYYDu6aOeMKLAOBWBKPVf6SWJLTtPAxTK0bWKFYFDygABSE PlRmwMdkBxAux6u6i74nTaJmVcMR+0FV75fgWkBSRpAarzFY+88LNtvZUUnT/urXL3IT AM7AKSlYM3b9WpM+LRFuA7yByz7XqA4052lOs9L5EOOhKAq0476Xp7Sf5sUZ9FtpMfPZ JmOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=KXe8SbN3x7nYQODTza1Ah1Hp2SNZJiX9dhK3CJAyN5k=; b=BRGbRgFWihuMuDlrswroNpOp9dyexBj5ryCU+DqE6tNaVOvn3riCwWFM4G3xDj1ZRM QnkxQ4phGNx5ksb4PUBpZYviDDGZrPTgPBGDbSLStCp10ouJraCAlckTs6y+j+L9eK7R cgMDiNYPJP97ieAVxlOI8DKgVPJC8vb66GVuq+Lqd4spweT2BssyrilawxGPAXwJeu5r VnsE3iGDIapVjz10j7jT07N4v9f4wkmTNuXKwSqtkUgAimMX8AhMssUIjiaRkzI/6hC/ qCvsci3xoeSRRKgwSeqdcdHkBEg/6t4wVT0nvwQGe8XVi8CqSww4iEqGI0MG3HIzLCwD 7RKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si3741449pfd.105.2019.04.04.06.21.16; Thu, 04 Apr 2019 06:21:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729757AbfDDNTJ (ORCPT + 99 others); Thu, 4 Apr 2019 09:19:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41212 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfDDNTJ (ORCPT ); Thu, 4 Apr 2019 09:19:09 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A837472657; Thu, 4 Apr 2019 13:19:03 +0000 (UTC) Received: from [10.18.17.208] (dhcp-17-208.bos.redhat.com [10.18.17.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFAED19C68; Thu, 4 Apr 2019 13:19:00 +0000 (UTC) Subject: Re: [PATCH v2 0/8] klp-convert To: Miroslav Benes Cc: Joao Moreira , live-patching@vger.kernel.org, pmladek@suse.cz, jikos@suse.cz, nstange@suse.de, jpoimboe@redhat.com, khlebnikov@yandex-team.ru, jeyu@kernel.org, matz@suse.de, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, linux-kbuild@vger.kernel.org, michal.lkml@markovi.net References: <20190301141313.15057-1-jmoreira@suse.de> <20190318191843.GA22702@redhat.com> <3423e586-5ae7-1dd2-8e5f-3930f168143b@suse.de> <0580fe97-7882-68c1-54f2-5778f47c5564@redhat.com> From: Joe Lawrence Message-ID: Date: Thu, 4 Apr 2019 09:19:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 04 Apr 2019 13:19:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/19 7:49 AM, Miroslav Benes wrote: > >> BTW, something I *just* noticed when putting together that toy out-of-tree >> module to test out multi-object livepatch modules is that we aren't >> considering out-of-tree symbols in Symbols.list. >> >> Perhaps we can save that for v4 or beyond, but maybe we want to re-arrange the >> klp-convert arguments to "klp-convert >> [Symbols.list ...]" where we treat everything after as a symbol list >> file? (This would assume we would generate a separate out-of-tree module >> Symbols.list file.) /thinking-out-loud > > I understand it could help the testing quite a bit right now, but do we > care about out-of-tree modules in general? > Yeah, this was only something I hit because I found it easier to construct OOT modules to test and share with Joao. I mentioned it because kpatch-build supports OOT and apparently some folks are using it: https://github.com/dynup/kpatch/pull/923 But like I said, we can push that off for another day for now. -- Joe