Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1241286yba; Thu, 4 Apr 2019 07:03:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzcF4gB5d6IeM1Tnd8xfq6CmFWlVN3DYu2329s9fuM01HLcMuil73BfHlLYZ15TxC7DsyQS X-Received: by 2002:a63:6ac1:: with SMTP id f184mr5684635pgc.25.1554386587707; Thu, 04 Apr 2019 07:03:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554386587; cv=none; d=google.com; s=arc-20160816; b=iUbtRFd4O66Mk3BHiRi3YSDCmbz502i7DI5yjqo+ypfcXUP3yMqoGCIDYY3SuM5qtf 5TlRg69DRuBSkf0jgep57yxrGa/uHzPytR5Orsd8NNxuH4j5KzLP+4z+jVCrWj6GQhxm RGInHjtMgspxw66/QoO2IqcHPKHWKfhb3RmFDmZMnrbn1H2DRcuwUSyO2K7AZAl9/p1f wOiu+pnXR4Sj3GLI8VNxhgC6SLHFKabHyNhQbvCv8D9U534IMHSeZ6dQDhdKQAeUZ+Cl DEQD2N58Ikp4a1mV5G44sK3rfirJpUCglYvxpJLR9rHt79QUrqpcVErX5pbVWn3X/p2Z 9y+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2xWH/2QIu/rWaaWXYOW/gUKeDYPZebOcBpmxtE1ty8w=; b=RGrtvxMG8MN2Eg0tNC5xw67qIv8qonC8VChHPIh5TxEo8l4A7Hob004WgWOvJqOVZh N4zPiNUwjKXgKVieNvkFvSJar2MCCF6cSLKSutTBcVRv0/WSbngF4aBWja+cJxhet+Kp tbyDgRqPgkxWuGjuETpeq4qDZ9MF49wZZ1pc7kRntL/bu+B4Mbd4bD7YRwjrwoDhZv+3 gJ7mDh7U12FQKjzeovYcm1J5rcy9qo4oxBLz41SKF78KNaDAZu23oGZqEsOUpUbulahX 7fifJfwNMLpa2uTuNxXTFgoNDZreA8eja/17GUa6k//xbprAA8GPlpo0zqIBbTuecw+t qrsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j184si17676091pfb.106.2019.04.04.07.02.51; Thu, 04 Apr 2019 07:03:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728764AbfDDOCD (ORCPT + 99 others); Thu, 4 Apr 2019 10:02:03 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:41830 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727039AbfDDOCD (ORCPT ); Thu, 4 Apr 2019 10:02:03 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 4C89972CC8C; Thu, 4 Apr 2019 17:02:01 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 40F497CCE4F; Thu, 4 Apr 2019 17:02:01 +0300 (MSK) Date: Thu, 4 Apr 2019 17:02:01 +0300 From: "Dmitry V. Levin" To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Andrew Morton , Andy Lutomirski , Roland McGrath , Oleg Nesterov , linux-arch@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , "Gustavo A. R. Silva" , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Dominik Brodowski , Andy Lutomirski , Kees Cook , "Eric W. Biederman" , Palmer Dabbelt , Will Drewry , Guo Ren Subject: Re: [PATCH 4/6 v3] csky: Fix syscall_get_arguments() and syscall_set_arguments() Message-ID: <20190404140200.GB4962@altlinux.org> References: <20190401134104.676620247@goodmis.org> <20190401134421.121919570@goodmis.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <20190401134421.121919570@goodmis.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 01, 2019 at 09:41:08AM -0400, Steven Rostedt wrote: > From: "Dmitry V. Levin" >=20 > C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1] > fields of struct pt_regs. >=20 > Due to an off-by-one bug and a bug in pointer arithmetic > syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead. > Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields > instead. >=20 > Link: http://lkml.kernel.org/r/20190329171230.GB32456@altlinux.org >=20 > Fixes: 4859bfca11c7d ("csky: System Call") > Cc: Ingo Molnar > Cc: Kees Cook > Cc: Andy Lutomirski > Cc: Will Drewry > Cc: Guo Ren > Cc: stable@vger.kernel.org # v4.20+ > Signed-off-by: Dmitry V. Levin > Signed-off-by: Steven Rostedt (VMware) According to https://lore.kernel.org/lkml/20190330004949.GA15705@guoren-Inspiron-7460/ the following tags could be added to this patch: Tested-by: Guo Ren Acked-by: Guo Ren --=20 ldv --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJcpg5YAAoJEAVFT+BVnCUIdTgP/Rm77MXR6eHh3/59ZVPESJzg BcQDjaBmQo9TloF3Ykj5Bl7a7aHzWyBVjecJp57u0itrGGRrxuFGKekr2GDFjS0d BbNIuHQEjx01MTPVolFxeVTpkB+tVLjVpkVou1GQ+YuPVyflKxashigXr7XpkaDI 3vKh4Ufj1TVJu+76gTHIONX57iwz5NyU2miNJ+6N53/agWMipEFdO/ZjEN4dm6lk W5bSWVXKwvONHzUHf/4zByVc9qWXsTG/uXQjhieHCk22Jxin6TZbP41a0OJF2A89 FjHFdVzNmrX84IEeoXOSzBwA0oKboa+2bY4mMLkmB09EPRURtmJ97tKiOR3PFt+Z v4bUhvI3Ri1+4rvl6hdLubGTmiEF9ixWUDZoYkHaDvS3w8IYTUZeu5ageO1lAts0 lz4kCCNuxN5sC46A0/wmNSdxDuWdd2B4eDZs2T+JcGJdjG3xTRAxYb3eYFISuksb v+1CA50fQfZJ77fTcNqgUYja64iNpA+L0jic98Npl9XqODL2kpz2roeVFJd7A/3j AMAmcvblmx22nIBTPuHi8wRhLsPDlTn/3LyAcastQQhNctGxBhjxHQBY75WNGshG 1pitcDV8Q52/rjtm9ZsoxJuueU4Yvs4skaWXVrIbmL46XULuN10oheH0b9YXFvDi 6T6VXgiXy9CmYHrM8fLa =556p -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--