Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1271481yba; Thu, 4 Apr 2019 07:34:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdWz3EpRXPO0v7KLw5vKxATD5bcImUqksF2uT4fuLo7DBeRD0EnvzPP0b3iNBTOzIUjZq/ X-Received: by 2002:a17:902:e01:: with SMTP id 1mr6865931plw.128.1554388473669; Thu, 04 Apr 2019 07:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554388473; cv=none; d=google.com; s=arc-20160816; b=E0L6AbtfkFk6sWP3pdOSyxwXJQ2nngT7k3yeGHkuNx8c5xahauEcWsNvfNs0lnSVBu zzHfWpOxtL1W48cSR+/hqEWv+bhWGRhpkL/nfBWg3NSjz5fur83/tQ7txHnwBCA9uW6t 2S5A11PM5TCE8m0H0ufsaNaEXRh0yXVtdhIiyEkxL4aP3PKr3CyCBUOJMz+O6YCGbk8y TXXy+h9v0NEbtdZcAXmFy+RmVQaz30G+bEJKGNm9iDk8niDuTqTzcOCFaeY5ozwr6PQv IV3NHgFAshIw6igexCkbuqu1x+zqkgfr46PrwnxWgpr6SkaiGREsHRAqY4qoQR8KDcpJ 2Iew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=nOP/JA+wn4vopL4vV3d3vvj66q9vk09t5Huh3KiADuo=; b=wBMe1/MHsLtk3fV8ijCEpxURgpBw80iGZgFMG7N49Jr+f/VwvTIPpi0wN0qc56bwoV 04mLblT9+5AkSmb+EmrLiuKWNKqny/TqhBW7+rmmyUDeijryNmrF9F2re3vB2gZMWtQ2 0ziBYUCPah6vQ26P+aXkfTB8ZooTu9HezSBcxMTcyx5RYSSOaJa5Itk227iEzQvJ67/R hqCrLG041jVmoX688NRSg4G5OVQwqmXGcx5bHENE2htpJO0J6IjXwA/b2UecJj02ALDb 2QdiEZYuhHPveSP5ZAXAnhQ3Nt5JEQ47HVKdOfEqtXpKLfGRDLl4c/vBbso/XOLhR1dO 9ehg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="F/oEscRt"; dkim=pass header.i=@codeaurora.org header.s=default header.b="F/oEscRt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si5844413pgd.243.2019.04.04.07.34.18; Thu, 04 Apr 2019 07:34:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="F/oEscRt"; dkim=pass header.i=@codeaurora.org header.s=default header.b="F/oEscRt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729033AbfDDOdf (ORCPT + 99 others); Thu, 4 Apr 2019 10:33:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54584 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727310AbfDDOde (ORCPT ); Thu, 4 Apr 2019 10:33:34 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EB80260790; Thu, 4 Apr 2019 14:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554388413; bh=EDBu7APradYeb47WtW3wHwz0R9xi7AITNLhdljWeTc8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F/oEscRt0sThZeqF/c16EZEtcrJQmLMQcytlCNLlpk9SI0SSF5OvC0LYGGuqm+YJw KREhraBfI+p8nOp49fq4oAJ8Dfn+HqEBMqsKVar2D3xAYHN5YVfJHW1xLSMe5pmhIJ s46NOTQsjzhpcBjUOFt5IB9ZlO2UNonygiq3t6MM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C2FBD6079C; Thu, 4 Apr 2019 14:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1554388413; bh=EDBu7APradYeb47WtW3wHwz0R9xi7AITNLhdljWeTc8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F/oEscRt0sThZeqF/c16EZEtcrJQmLMQcytlCNLlpk9SI0SSF5OvC0LYGGuqm+YJw KREhraBfI+p8nOp49fq4oAJ8Dfn+HqEBMqsKVar2D3xAYHN5YVfJHW1xLSMe5pmhIJ s46NOTQsjzhpcBjUOFt5IB9ZlO2UNonygiq3t6MM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C2FBD6079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Colin King Cc: "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath6kl: remove redundant check of status != 0 References: <20190404134723.24667-1-colin.king@canonical.com> Date: Thu, 04 Apr 2019 17:33:28 +0300 In-Reply-To: <20190404134723.24667-1-colin.king@canonical.com> (Colin King's message of "Thu, 4 Apr 2019 14:47:23 +0100") Message-ID: <87sguxsuvb.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") Is the coverity id missing? -- Kalle Valo