Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1276993yba; Thu, 4 Apr 2019 07:40:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwb1Nt+GvdfwjmRUsMZaaex5JsRYcGwrWtc5Cz99D6JjcCZZLa0KzgR6NtEYjPnrBgkcPcL X-Received: by 2002:a63:ce50:: with SMTP id r16mr3186435pgi.89.1554388838109; Thu, 04 Apr 2019 07:40:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554388838; cv=none; d=google.com; s=arc-20160816; b=mhNmsdREV8P5V8oDEWQWPOqGK1vYHjh9BKts0Qb20uhEGRrplCNSZnbqeKCfxma+DL w+wiiQdywY2fWc+E1JyeZxv/tvADEzdEP2MBqcxzJzqKj6jXYjcnPeiKPes2l22S2YAu uq4cPeLhJiCT6l1nNCc4kUa3aO0zt2oCZrZZZpaz+Q0AFj25L442BRJln1wNx495d8j5 FZu8s/icXqTcSIl9pmuyTnckPP5oqOTDqCxQzIEezhiBh+KLBeDMmBB0l3tjfXpmzJ/J HfCrxRjHieJk8nC4bHwpS1shE0X4ZmTrWDIrktNi5L998dERPMwyt1S6cP4hRo+w11UM lzzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=2nsBitIrQDU00C7pV7eoPW99k5WkEBUd+i7nBmDCTKU=; b=VZ1vdNyUwBKKaWpo7Bqb24Kaxp5tALYheD19LrzkwboIHtZgc5K5Z4tP0zdPAVtowd AnRhwPZzaZTskbm7mddblsEua+3iOVh65G6lR5KWWY0MDcL9H4i0tYS7UD2L/a0L26mC WF5uDYPrYzauqQJuu48ocBrk+OFMlCqsZOKzAbHnnjd0slEd+EgbbWWODBwwyKfkmEfJ vjt0RyGpDt0fPyqp+o9VkaFSwqVfqSF9lMWjwJeR8dgt3ZhgXUnOXvXDFyPY7GGAhmik 9u1kDCr4y2lUNjPB+6Bmrt7yPEVUTEmdWYYq5xCSkXZ8ZpUeCkW7PGPdFJinXWpNgAzx MhzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ytkjuPb2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si16170080plo.118.2019.04.04.07.40.22; Thu, 04 Apr 2019 07:40:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ytkjuPb2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbfDDOh6 (ORCPT + 99 others); Thu, 4 Apr 2019 10:37:58 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:38420 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbfDDOh6 (ORCPT ); Thu, 4 Apr 2019 10:37:58 -0400 Received: by mail-pf1-f194.google.com with SMTP id 10so1476567pfo.5 for ; Thu, 04 Apr 2019 07:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2nsBitIrQDU00C7pV7eoPW99k5WkEBUd+i7nBmDCTKU=; b=ytkjuPb2YgAN983gXFG8uvfmjXWj2iI9akDbFpg2hMOO80E8vd/vfDWUsJeCcU9gmY BhjF1RivYDQRxV2wjBuSM0ZZm4G3CM5p+2mqfIDHrWO2tVX221hg6WLXfqQJ1Rujt0bn 0LFx1ggs7uL9aJw54MYM195RLrlHrWWSOD+LMvACZCnM+r4+88bkiEgBQT7E2T9txgEs 3Yn7L5kEdzN5ZdyjFMy/0CtJh4yxPH+TIHyOhGA9Nw8Al1ER57pMHJWw7yJc4luPtj4E 3kI6fWyE63/cnmY7oYwoqgcL/WtRD/8l4wu+SNkVUdENRpBz8h+ARiZAAPuM9cVTtef0 G1rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2nsBitIrQDU00C7pV7eoPW99k5WkEBUd+i7nBmDCTKU=; b=Y3Hru3OR4iGFGfMmRpccxt0RZFqgNyCQ5Jmnwbr0cA5/1M39pDaON+Rc1Lj4S7J1fH XIB31bfUm9sKKSzvPI4io1QT04Wt06k7z4jRHp8rKU2rZf4BSZmIgH1SLMEXUHsLF817 0eEiMnEl0HUoezhEmfwOHkkAZz0Y4oBR+wRpGJIWfWv3SYJ1FbZybuc9ZlFgg9O7JDSV LTdrhaAojJCOZQXRR4tspBuvc9av5hbMvUOhPWKV9AknK2BSANpucHY/dvaFSXVztIBA 0OeR0L1oSTnfrFqnSZYvIOt0pzewUjagupLDsrohbPOF9NDWvDIQf/cFjQzhfxDZ9TXK c2og== X-Gm-Message-State: APjAAAU9+4HttlGxH64+uVToNJrXcys2Q5kfgdl3XEVxpy9FpM4S9rsQ 0kYtLZo6rCXYWSFh+Z71aOyXu01uwNs= X-Received: by 2002:a63:28c:: with SMTP id 134mr6359794pgc.278.1554388675463; Thu, 04 Apr 2019 07:37:55 -0700 (PDT) Received: from [172.20.10.3] ([107.72.96.208]) by smtp.gmail.com with ESMTPSA id i15sm25043254pfd.162.2019.04.04.07.37.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Apr 2019 07:37:54 -0700 (PDT) Subject: Re: [PATCH 1/1] blk-mq: do not reset plug->rq_count before the list is sorted To: Dongli Zhang Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1554346664-24038-1-git-send-email-dongli.zhang@oracle.com> From: Jens Axboe Message-ID: Date: Thu, 4 Apr 2019 08:37:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554346664-24038-1-git-send-email-dongli.zhang@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/19 8:57 PM, Dongli Zhang wrote: > We would never be able to sort the list if we first reset plug->rq_count > which is used in conditional check later. Well, that was pretty stupid. Thanks for the patch, applied. -- Jens Axboe