Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1300564yba; Thu, 4 Apr 2019 08:08:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyN3VO9fZd7vhSdZBl/WPVJKqcADnCFyPb9HjZItqhrrsffYYlFEfN/cRBwC0tVETPwYa4S X-Received: by 2002:a62:1b03:: with SMTP id b3mr6553094pfb.150.1554390507353; Thu, 04 Apr 2019 08:08:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554390507; cv=none; d=google.com; s=arc-20160816; b=rQyh6X1gs+nOIHIIBi1G+oNB6Fiy1bir5CY5YNYUb1IZVLuiN+OQSVNGSVfY1EJLDD Es97b5RNbSBMkD9pprZESQrjZbxzXwxAy8/Wl3JP1o6e26Bnn1tKSNkPw61IG+x994La u4+Ueu0r6fnUQw7mhN8CVrkmnVJUv2ob3CYVRLEs+VajhQrnqlJSsdCX5ij8Kwiu7VsE smBTNhmfBa+oUCj8bQjNTHcDbJerQ7cBo5VTEduRPjX95GB/JA936LBhfcAi21YndSYt cpYMWeXtLf/I8xvva0r0/D6nngy1J6HcKuBLVEyAFQJEt3Td+CFmo4k01gLoEtMJ/f+K QclQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=uKFvFD4JdeYKBh6CD8p305ar+araeIBeh7/wlOpLXRc=; b=XzxN+KM7MA7anhrpV5KfsMJ2FjLluC5LmW5bW1EuTusKXqhRtkIAW2q6k03kOUjP0h 7QWonEvshMAf7X0uAlSKTfJB+BxY4hRCOV4ILJ4Nj59vxYii7nss7fsYSyeXlIoRR8ZD ObEuvEQ1XGlClxOB3xnMzp8aqmWEtBiinQqzKkyobuB//bUOmbMJ1xTR/oVNXPcZ8SVq smoCA/m/dBQM9QUYw03/WQrwJYb58H6ixiAL19dRAPcHmar27nI4Hm1qz9/oU5ZfxPb0 A5DIOarX7/17YweP6QOLDrcISNqpPv2AHoHeSWYX4Hil52oRCj87sH/S0X3sIITvX52m eT9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y191si16075060pgd.218.2019.04.04.08.08.08; Thu, 04 Apr 2019 08:08:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbfDDPGT (ORCPT + 99 others); Thu, 4 Apr 2019 11:06:19 -0400 Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:33949 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727212AbfDDPGT (ORCPT ); Thu, 4 Apr 2019 11:06:19 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 6D6B4182CED34; Thu, 4 Apr 2019 15:06:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:800:857:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1535:1543:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3865:3867:3871:4321:4605:5007:6119:6742:7875:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12555:12760:13161:13229:13439:14093:14097:14181:14394:14659:14721:21080:21627:21773:21789:30054:30070,0,RBL:47.151.153.53:@perches.com:.lbl8.mailshell.net-62.14.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:34,LUA_SUMMARY:none X-HE-Tag: angle99_3602eec8fc958 X-Filterd-Recvd-Size: 5086 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Apr 2019 15:06:11 +0000 (UTC) Message-ID: Subject: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging From: Joe Perches To: Guido =?ISO-8859-1?Q?G=FCnther?= Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Kevin Hilman , Manivannan Sadhasivam , Shawn Guo , Jagan Teki , Martin Blumenstingl , Johan Hovold , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Nicolas Ferre , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Ravnborg Date: Thu, 04 Apr 2019 08:06:09 -0700 In-Reply-To: <20190404105359.GA8255@bogon.m.sigxcpu.org> References: <20190403161735.GN5238@ulmo> <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> <20190404105359.GA8255@bogon.m.sigxcpu.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These were missing '\n' terminations, add them. Signed-off-by: Joe Perches --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c index 158a6d548068..d88ea8da2ec2 100644 --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) ret = mipi_dsi_dcs_exit_sleep_mode(dsi); if (ret < 0) { - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); return ret; } /* Panel is operational 120 msec after reset */ @@ -132,7 +132,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) if (ret) return ret; - DRM_DEV_DEBUG_DRIVER(dev, "Panel init sequence done"); + DRM_DEV_DEBUG_DRIVER(dev, "Panel init sequence done\n"); return 0; } @@ -172,7 +172,7 @@ static int jh057n_prepare(struct drm_panel *panel) if (ctx->prepared) return 0; - DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel."); + DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel\n"); gpiod_set_value_cansleep(ctx->reset_gpio, 1); usleep_range(20, 40); gpiod_set_value_cansleep(ctx->reset_gpio, 0); @@ -180,7 +180,8 @@ static int jh057n_prepare(struct drm_panel *panel) ret = jh057n_init_sequence(ctx); if (ret < 0) { - DRM_DEV_ERROR(ctx->dev, "Panel init sequence failed: %d", ret); + DRM_DEV_ERROR(ctx->dev, "Panel init sequence failed: %d\n", + ret); return ret; } @@ -212,7 +213,7 @@ static int jh057n_get_modes(struct drm_panel *panel) mode = drm_mode_duplicate(panel->drm, &default_mode); if (!mode) { - DRM_DEV_ERROR(ctx->dev, "Failed to add mode %ux%u@%u", + DRM_DEV_ERROR(ctx->dev, "Failed to add mode %ux%u@%u\n", default_mode.hdisplay, default_mode.vdisplay, default_mode.vrefresh); return -ENOMEM; @@ -241,7 +242,7 @@ static int allpixelson_set(void *data, u64 val) struct jh057n *ctx = data; struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); - DRM_DEV_DEBUG_DRIVER(ctx->dev, "Setting all pixels on"); + DRM_DEV_DEBUG_DRIVER(ctx->dev, "Setting all pixels on\n"); dsi_generic_write_seq(dsi, ST7703_CMD_ALL_PIXEL_ON); msleep(val * 1000); /* Reset the panel to get video back */ @@ -290,7 +291,7 @@ static int jh057n_probe(struct mipi_dsi_device *dsi) ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ctx->reset_gpio)) { - DRM_DEV_ERROR(dev, "cannot get reset gpio"); + DRM_DEV_ERROR(dev, "cannot get reset gpio\n"); return PTR_ERR(ctx->reset_gpio); } @@ -315,12 +316,12 @@ static int jh057n_probe(struct mipi_dsi_device *dsi) ret = mipi_dsi_attach(dsi); if (ret < 0) { - DRM_DEV_ERROR(dev, "mipi_dsi_attach failed. Is host ready?"); + DRM_DEV_ERROR(dev, "mipi_dsi_attach failed. Is host ready?\n"); drm_panel_remove(&ctx->panel); return ret; } - DRM_DEV_INFO(dev, "%ux%u@%u %ubpp dsi %udl - ready", + DRM_DEV_INFO(dev, "%ux%u@%u %ubpp dsi %udl - ready\n", default_mode.hdisplay, default_mode.vdisplay, default_mode.vrefresh, mipi_dsi_pixel_format_to_bpp(dsi->format), dsi->lanes);