Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1387335yba; Thu, 4 Apr 2019 09:43:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwFqPRY1eQmgopon41qd0kOiWyWgkmrBoSuS7WBUKpurO3XueWQX3ZKgOVrTWK6SZB+rvKK X-Received: by 2002:a63:4a5f:: with SMTP id j31mr6852337pgl.369.1554396197626; Thu, 04 Apr 2019 09:43:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554396197; cv=none; d=google.com; s=arc-20160816; b=LwrC3t9yx/VuApdQwLHmxah9YaqrPeXpWVex6GCVJtbCT1fEJ2BbynYkkJs1TfBFbk MjprnLRTb6yKB//vztjzkv60jY7i1pS58JWn8Xro7OaKyexof3rLe21UHOBMQ9Nb60jR dRqDQMOIXg+91dKcjMleueNxdIuDoU5qQ+89cz6FZJTZhiYF2MGK9Qj4iQ8zCbV2kd7F fc6GrFxgjQQ9wGpeNQu36GSwxq7kj1LK9Fzx8fArJtsYNjbSFEdQnhQsM9sx/EuSw00u oj1OvarwgTFVuVwbJDpbsrocBTyL9M9He24pSoCL2UfPxXkcSGI9ypdUYsLXObaZ8ls/ nEIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature; bh=28+09XFOqkmUno0MP/WfSRXRXy04JRnokQl+mHKKxO4=; b=GCazMADzhzNuQSgRe3y2vSMDpA6gRP9iWbOLEbsVBQbPoU1vyXtLktn7N8Lhw6gUYX wf5Trbm8HToksHIm0otHWi/2NOo7zlDM15rbiRhx/5uXi8a41NrakxdQNvs8Rud3mljU BxXHpzRvgjO2B312oHmsxgti5q9gzybYrKOkLDSH5BkZiYgPPFhh2RzEfFhKX1xD9rVY Uw62il1V2V5dl5Sdj8X3RZo1ym3Hz0mTkXaHySBjyz6Sg61s7mNEIv0aBimi5rDErLl1 +qmJj7sqU52V6aN4lN4YFgb5aVdjBWj+N3+gfTlNlrSJSSLp2qjrn/3KRxLvktrEKbtA 2RWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw header.b=QCkR8nbv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g75si17193047pfg.49.2019.04.04.09.43.01; Thu, 04 Apr 2019 09:43:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw header.b=QCkR8nbv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729393AbfDDQky (ORCPT + 99 others); Thu, 4 Apr 2019 12:40:54 -0400 Received: from a9-92.smtp-out.amazonses.com ([54.240.9.92]:33912 "EHLO a9-92.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbfDDQkx (ORCPT ); Thu, 4 Apr 2019 12:40:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1554396052; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=28+09XFOqkmUno0MP/WfSRXRXy04JRnokQl+mHKKxO4=; b=QCkR8nbvGPc46188u3FKsmfoRKR+C8SJcpzLMQepDco+/v/jNbIM1i9oRzKcsRGJ u4bwBFfxfBEwpyaeWRQUN77Wh7CMdEUPsGcX/QH5IPyDlUTiZjZS9yRsV10kZfiS1On C2yv3QO2mEYO/RwYRw5MUIOZhGdUdYfLEenOnXIk= Date: Thu, 4 Apr 2019 16:40:52 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Vlastimil Babka cc: linux-mm@kvack.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [RFC 2/2] mm, slub: add missing kmem_cache_debug() checks In-Reply-To: <20190404091531.9815-3-vbabka@suse.cz> Message-ID: <01000169e9397c8b-5e09e11d-50f7-4622-b369-d684d17856c9-000000@email.amazonses.com> References: <20190404091531.9815-1-vbabka@suse.cz> <20190404091531.9815-3-vbabka@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2019.04.04-54.240.9.92 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Apr 2019, Vlastimil Babka wrote: > Some debugging checks in SLUB are not hidden behind kmem_cache_debug() check. > Add the check so that those places can also benefit from reduced overhead > thanks to the the static key added by the previous patch. Hmmm... I would not expect too much of a benefit from these changes since most of the stuff is actually not on the hot path.