Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Weiny, Ira" <ira.weiny@intel.com>
To:     William Kucharski <william.kucharski@oracle.com>,
        Huang Shijie <sjhuang@iluvatar.ai>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mm/gup.c: fix the wrong comments
Thread-Topic: [PATCH] mm/gup.c: fix the wrong comments
Thread-Index: AQHU6rdootqQqf6MVU2Y2vuXC43Qn6YsVAoA///ka7A=
Date:   Thu, 4 Apr 2019 16:53:53 +0000
Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E79C99E19@CRSMSX101.amr.corp.intel.com>
References: <20190404072347.3440-1-sjhuang@iluvatar.ai>
 <3D9A544A-D447-4FD2-87A5-211588D6F3E5@oracle.com>
In-Reply-To: <3D9A544A-D447-4FD2-87A5-211588D6F3E5@oracle.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@iluvatar.ai> wrote:
> >
> >
> > + * This function is different from the get_user_pages_unlocked():
> > + *      The @pages may has different page order with the result
> > + *      got by get_user_pages_unlocked().
> > + *
> 
> I suggest a slight rewrite of the comment, something like:
> 
> * Note this routine may fill the pages array with entries in a
> * different order than get_user_pages_unlocked(), which may cause
> * issues for callers expecting the routines to be equivalent.

This is good too.  :-D

Ira