Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1632206yba; Thu, 4 Apr 2019 14:57:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWhFsXOaBXyPFjRGEzDiyhNDW1ZCcHiucfFHx6ZDMQpl06wKEv/RCG/I3+wvBY/+91+tT3 X-Received: by 2002:a17:902:ab87:: with SMTP id f7mr8888239plr.85.1554415036859; Thu, 04 Apr 2019 14:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554415036; cv=none; d=google.com; s=arc-20160816; b=qSi3K3t83fMqCHmqLU8YxOCmkIQ5HjybYGcSj1FZbVp6PKEiWF6h1syB7YAenj17AG Zj7JXZeNi180mMG5CfUzDrTud/GLTVLnEDYsZwlnhdIjayjvPVxjnLVfJAfrC8HRPJZS Sr3V1EQ/WzvQL4VkcPXoxQq24knqffzu7kaJwxfhEc4N152DW21+Dktb6GZ4R0xJ8JLR nQZTXm8HrA46Ahyol+z9GRy9+Iarq/NUGBBTgqiyE0ENjiJetWwmCdN+6t/lE/cNtjY/ /waLEvPdMp9F9v3AQQdw6tpoJRO+YzlmxGiSk9N1qum5u2tTueiOtUI47z7mdPjmhpTS tKgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R6qHg8kDhV/kTvTqC5qkrdMPPo12X+d03p3KxzHAKw0=; b=bTriwxs0p2zxBWf9auhXo9kQ3A7cfyTn1rvHpLq0k5u4BqKV6PKLUg1TlrBsDy7+hQ jLnUSJQMTDa/olcbH/BVl1i95SRGGQ6uCBRhln1pvFQ/hN062SVpwK8SxDAGKVDGVcKI 4kCxJyacAeKeMT1EgoCFbamZMWBrnUGfbq0hx/hv4tFWbCcKB1UJ0N5dGYLDqO28cWtN mFRNNMd0Z834AkIFB5ivh0u1ncYFhLf4Iz9PcgST3bZzvxBcZikw8jw1zKJKghwSmVpj 3O+KYwOZu2OCFCQ7MeR5ZrrxDwLhL08VcYKgX5sA6HEBwgzV6VpATJI8wB8g8E+zQnWp GRWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zE+P+rp/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x30si17753088pgl.477.2019.04.04.14.57.01; Thu, 04 Apr 2019 14:57:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zE+P+rp/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731102AbfDDUjM (ORCPT + 99 others); Thu, 4 Apr 2019 16:39:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:47356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729400AbfDDUjM (ORCPT ); Thu, 4 Apr 2019 16:39:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D03C20663; Thu, 4 Apr 2019 20:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554410351; bh=rTs5v1L17kQH/iEWdJ4/swpmSDYtyjqb2Nkp1p5ObKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zE+P+rp/ETe04cjbzKS31qh05RU0YiFMuceQpAypUXPuG56ErfkdzSGbkiwYhoc52 51FhLRO18scbDATcAwyf0aygupANWtpfUMp4YpismLHpQpqXARBGzXYik5pe2cgAj9 fXYziRQN6as0sgtvv6/9W8/5byxDGZAAiqu8yUTs= Date: Thu, 4 Apr 2019 22:35:49 +0200 From: Greg Kroah-Hartman To: Okash Khawaja Cc: Samuel Thibault , Gregory Nowak , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , Peter Hurley , Jiri Slaby , speakup@linux-speakup.org, John Covici , Ben Hutchings , Chris Brannon Subject: Re: [PATCH 1/2] vt: selection: allow functions to be called from inside kernel Message-ID: <20190404203549.GA9319@kroah.com> References: <20190404194530.1170-1-okash.khawaja@gmail.com> <20190404194530.1170-2-okash.khawaja@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190404194530.1170-2-okash.khawaja@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2019 at 08:45:29PM +0100, Okash Khawaja wrote: > diff --git a/include/linux/selection.h b/include/linux/selection.h > index a8f5b97b216f..171d77dfc825 100644 > --- a/include/linux/selection.h > +++ b/include/linux/selection.h > @@ -11,13 +11,12 @@ > #include > #include > > -struct tty_struct; > - Nit, why remove these lines? thanks, greg k-h