Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1839027yba; Thu, 4 Apr 2019 20:39:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwbYVpB/OvUqOMRCnxt9J4rZ/r6HdKNig7L+Ky0jrztnLEWKYE/ZmQ17auaFpZEvEVUoll0 X-Received: by 2002:a62:524e:: with SMTP id g75mr9775383pfb.106.1554435552011; Thu, 04 Apr 2019 20:39:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554435552; cv=none; d=google.com; s=arc-20160816; b=JfwoxiOxy3C8MUIJtgUnzADKBCKY7I5CZ6/RpCCT6ecsxi0B0iUJuH3wgXB/oqFYFo U4m9TTtXVzvGp65I7yApb+wNwmvhNdJ2qThc5MI2gn2B1YhE+hj56Jbk6hvbufwfl/aq KdJnP7Ae5IfQf2WqU30kPL/3XNXEfdiDT8P5gyyYdoX+zW+vd3mgFbjzT1ppW1fAnkX1 wqEwPdp2fD6GFPKv9YYYv/W+lcMPqoDK3VshgFUolON33AzLpWGQ7+I2b+7wMonxtodz sLYrwn+Be+IuHU6NFUsrQAj36xr/EAVuwSXaYlnyaoB6lpVKlR4OZ9VSVoJniJkXAvaz bPtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=8HYtJNnTL1rydVt3yKyaIYNXoqgoDNkL+zXW+PVMBXQ=; b=Yvfq0uGcC+4wCxc08PTQZO3pl4PVJ2MTuKLG1MKAh77rHGYVn5ANdlttHLE4ZJK65l bTM20EdffVnpgF5My5B064s9c8MJyQ/akhoxyWfzomxmpmlmMAmXUoiovQsoV23WBPt6 qJPiyvCfqVUiZq3q1PmyxkDrD0/0A9fsUSrQoNjh4bt9XqM7aiUVM/B3j+c21+acilFj LlkXxch16UI/oDPBk4LzGskbB/03ZQOVhsKjYfulMwNQoJ34MtkOk/bOR69qQ5AYIF9C 2OM07nsCUwTcm5BNPZpt3ZxzLKW+M0gt2RGryiZvTPsQ86WsVsoX9ZloBTXZpcKxInFc x3sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dW7MutkR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d69si2117217pgc.451.2019.04.04.20.38.56; Thu, 04 Apr 2019 20:39:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dW7MutkR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729861AbfDEDgk (ORCPT + 99 others); Thu, 4 Apr 2019 23:36:40 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:46613 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729631AbfDEDgk (ORCPT ); Thu, 4 Apr 2019 23:36:40 -0400 Received: by mail-lj1-f196.google.com with SMTP id h21so3915258ljk.13 for ; Thu, 04 Apr 2019 20:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8HYtJNnTL1rydVt3yKyaIYNXoqgoDNkL+zXW+PVMBXQ=; b=dW7MutkREMGZjWeDGrfQNmpb5B8U3cid1xRYx788W1KHbKEVT2IYyyUqkXztrjF+Hb n2bS5aQ/Vsvq+gGj7G6pFQ9zp8DUrHz/GNiUVpc57FyacF5I+0/sMxl9U1+hPSzdI+N0 NqdVyifOLmsD9+QbV+B007sO1x5d/OLmgrLW7M3QckQhza+CPNDTTu/D+wIw/Eire9+t +HXS3/VTaCxxYELyKTU2AoFwvWIh1P5UMP8vo0wVLh04gTgEjetZyyJx1+hOrjMVw9uM XoGaay3Ht7aRzzRtUBrdY3A76FgF1T2lbdVtE7wYAVt9jSECu6dSMytNEqipHOcC/SmM LA1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8HYtJNnTL1rydVt3yKyaIYNXoqgoDNkL+zXW+PVMBXQ=; b=qwmb4zcEfeVozhJGeFzQRhwTl/j0DAwp0mgV9WLrlgDVegBHLrBcrFOgBnxbbZZDKC VMQJ5KzwNMcVmydMCiLTca5vuhIxw7PdXXJxAAvkZdixTNOFxS3xaCx0k8Obo0RGCeZx jQiOGn1JnfRRaux45PPGtLOCJiX0Apm2DwL0I8xTZNVfV8KCEbu9YY/bWxDdb0vMUOKm JhY6LYjaOLZ2j6qpr2XEaYrknUKdZZ7vcAdkS7BxK33lnX3EsW3BHld/XnSYb57NlS1F U7gJhFinUb/DMLqh+uSHRkcAIPLuEU7H9xw81hA0qdTech2iqtcYEHlphkuwrso05Sk8 +9gw== X-Gm-Message-State: APjAAAX7dTTCN11qaKPEg9CmBukeRYy6xal7cMGdWfLZcFnvcjArWLFW X7jDdl3Av/N29w1NQfd1J0gS9YeR8jcFjoRNyLsngA== X-Received: by 2002:a2e:4a1a:: with SMTP id x26mr5346674lja.49.1554435397995; Thu, 04 Apr 2019 20:36:37 -0700 (PDT) MIME-Version: 1.0 References: <20190312151911.2207-1-pakki001@umn.edu> In-Reply-To: <20190312151911.2207-1-pakki001@umn.edu> From: Linus Walleij Date: Fri, 5 Apr 2019 10:36:25 +0700 Message-ID: Subject: Re: [PATCH] pinctrl: axp209: Fix NULL pointer dereference after allocation To: Aditya Pakki Cc: Kangjie Lu , Chen-Yu Tsai , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 10:19 PM Aditya Pakki wrote: > axp20x_build_funcs_groups allocates groups via devm_kcalloc and tries to > dereference without checking for NULL. This patch avoids such a > scenario. > > Signed-off-by: Aditya Pakki Patch applied. Yours, Linus Walleij