Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp21749yba; Fri, 5 Apr 2019 00:56:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxV6tsz8m7+FYyddAGsqAgYgV7dP1I3i0iz1WYXvKkQ3WA0eOfeiG5e26Pv+guE8pkGKDNT X-Received: by 2002:aa7:8694:: with SMTP id d20mr11050001pfo.81.1554450991346; Fri, 05 Apr 2019 00:56:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554450991; cv=none; d=google.com; s=arc-20160816; b=0w/f6Gmv+Xb4CeXTFMhQ8vx3zOgVO5apQRqmV8d61XJMNg3MU/97GrhOeXa/mzZIPt 0TBYQqJjB8r+X7OK5rnCuYpapJhkN+VHrzF9itR+GE+RdDneNClym75JmS9kaQ+GVo91 kF72JgpoqTCy+PfbfyKVuIsdqIZzZWCrw8Mzk0u+ZoGXyCYwyJIZCe7+GTe41HM4DiPr hp7gXzONA22bvsp5onIcO6GASYkd+YDKmDR58gnS0w32chQtxefbAkGECaUemdrBDdkM pnEKBU0wqBnukwMu/OTokBZyH7eVhLCT0Jopb1vDdccOQTO/c+hMs41iY/raMW0az2PB ji7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:to:subject :references:cc:dkim-signature; bh=+t5Y9ottKZkbxhWfz1hM8M9NmAE26CpO8WoHKIIqHXo=; b=gon6aWSmzc03jwRAoWiG/gO2WzctnQRasNnr2Yv7UMOKiTDK89EPD+hkOvFBzJ3p/M 0SplgzLVA+kEg4Ais0z+ML1NgSIBX5Gu8em3cFotvqRgmcxvW+4eIanbepJFLzVBKf8w FHM+1CUyHxyZnjFq8ki0tgDm4L8WbzofhP/1lQR8ylYqdO4gEWIoK36a/2i22cKuw0/r YeJgTncUUrfcvxyWWE+yBbU4RWKHQx2/bPeAJiT2WHMM9RaxVmER9nJUbLC2DzGrQbUa E3z5t1l0mrCSohc4nHQdwacx/dU5oh2E4x3cjswjIgAc/58kam5jC/JHaZ1FrVHf8emk tm6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=NQKWxhA+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u30si19343309pfl.23.2019.04.05.00.56.16; Fri, 05 Apr 2019 00:56:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=NQKWxhA+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730353AbfDEHzZ (ORCPT + 99 others); Fri, 5 Apr 2019 03:55:25 -0400 Received: from mout.web.de ([217.72.192.78]:51931 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbfDEHzY (ORCPT ); Fri, 5 Apr 2019 03:55:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554450894; bh=hf9dEREKxEenkihgK8pKnqNTae64ydfo8H9aPfN1PAQ=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=NQKWxhA+zwG8uxeDk0VX+7cAvdCDYtnScuORwUygZkw4rYhWih8Zx97Bp2BVaqXMc PnTZ5VguU9q6/lQAYRCLXJ70cjHko+TkOesbZI0w0Tw74/DRgSFm/2NxaG3eGUCNuR IEXA/gLH+03U/x9qeygRPCtENBchsm5bIl38Pa38= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.156.119]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LmLc6-1gchx62xF4-00Zzwi; Fri, 05 Apr 2019 09:54:54 +0200 Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anirudha Sarangi , John Linn , Michal Simek , Yi Wang References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak To: Wen Yang , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Fri, 5 Apr 2019 09:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Provags-ID: V03:K1:uhJqR1yCCBFeVqpSILNxEQPi6Ns72Y2J9OoFw4Yb6rFJlZOcc6V 4FdJfoK2gPl+qR28M0fwirrMi+YlkypjrpwZR+wp01M7BRZ2ZLkE6c7R6JZnOcQukLAjHTV 2KMHbGhYK1co3f8yAjdo1UsUtpCmvaptZBhziMu28XSluurSa7/ltTL78zSoJi/HmQCzJYe mI4eXSnhDb8Opwn70es/w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wkW3FtME1Ss=:omzqLgFjqP8NMDl6JrmiGJ g0N3xVHW9t4+EWUeRS5DQzodoj75AdKBxE+CfXLDA9VUx+XbrxNjDRRvxImS02kcZXeaZKasK QIg6p+rjJIGGSULDJ1FJuZEdwHa7R0Qp2OF1rkYXRDWTFFWKcwHY8Rp7FkC0kJ5l83Bm3pHBU etZA8mg51eiFXqRYxhz7O/6iuCsz2QVxVEq4fGljXW/i3WvkwHZ8Vl/+qx+dFBs60cFOLpGmS ZkYDoaAvmxjJfwLKqTQsI3EEyyFPSy0FVhL6i5fmspA8UfZNcjt5ezTXhMArIqEcLTvnMv4eF +tNFoIx+3q6702xT2vk8j5m6LnDIQd5bTuJj1Jm9wxXDwX544Y3lAClqRszmumwUNuQpd9Yz/ HJ2fsnywJPj049uSGyfUeEMhccDhn5KVo+AKZr59OouqYsuGRE4ZBndfuqQbjhZ5BMHMh6OqM g7UKTdZTK4dTcJ7fhuVJY2qT0A1aIK25oC7mbF/298VlH/aKAZLQbmK1QuOOZpqBFyDGEAg/v vbGRlImv7Srsfj9JxKZubiUDde5NSH8fTWfClxDYHQW6B68bFH/SIJtUO6xMEQY83SXBJKwaQ Bkm/7Czx1n0xg7oE/yyQXzRbtvPCSDJnGlZGZEV4hgKjErK3AlQNRtxdxtllIFv4LI4mBYgYp FbXLnqMOn38ur/S0LIqcO4h9Kk8iFcUbrh9ep4OOVmo+UhuHvh3xvCSBfB3/FFOVo2t1zNDA+ Qp42amvmeMC8U+v5A8wL+Q0APydXDEpb+jIOnbDwKL0lFsZUJ6c6fGK7pjG7SjcOqFlDtgVGd pOr8+NipwRdkSfh2AYSAKNDce7kOUvIHHad1CtUmytqEpxZhUE7OY4TyJ+sDCj/UX0IniyqRM xAjuDIoKHeqK74tkhqniiqMVVRIcKek4nqX51k2kgdP0Xj4WpQTUM9b1BwGW42Xrn+R1oQfKE EF9rRqafcow== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev) > ret = of_address_to_resource(np, 0, &dmares); > if (ret) { > dev_err(&pdev->dev, "unable to get DMA resource\n"); > + of_node_put(np); > goto free_netdev; > } > lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares); > if (IS_ERR(lp->dma_regs)) { > dev_err(&pdev->dev, "could not map DMA regs\n"); > ret = PTR_ERR(lp->dma_regs); > + of_node_put(np); > goto free_netdev; > } How do you think about to move these put calls to an additional jump target for the desired exception handling? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/xilinx/xilinx_axienet_main.c?id=fa3a419d2f674b431d38748cb58fb7da17ee8949#n1621 Regards, Markus