Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp80967yba; Fri, 5 Apr 2019 02:25:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVD3y5DWYH2+vi9gTonYWyvLCJbznUxxLcjFtrGAYwcZIEVoIhvm+0sCWtYCJAaxOyL9jS X-Received: by 2002:aa7:9392:: with SMTP id t18mr11360761pfe.45.1554456301389; Fri, 05 Apr 2019 02:25:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554456301; cv=none; d=google.com; s=arc-20160816; b=P6q0NdFmH4mYFCgIe5nG1ow6DsoRwSZDsDUtmEGgmzwQAno3/2NpZso4rCJRoh2veX Aq+X6IKF6PFFT1qLynYWr2OcU2QLXklZAtmrB8SWKHSxaRnuMK/cft5cvwDnFs8VJB7T p+u4Hb/ITnWp3QzerPeFlvuyrq5YbDb2eYKcJ2iMePtwgRfyABTrgOxMp+CPEplSyslb Tnwo/37axDjISv+MDTmJNr+hToT7lH+PEzGUf6TnobuPBRjglbgMHZdKkvpHomQFtl0B KXChg6HdWpZqzDMkocFkMjhnNHHPQLNRQkY8fTfNn9vJE3BAjpaOB6YHU+MyDjTSql1D DG2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=N74Gigeamf6uW7mNOcPxG0cICPEw7tgItm/aODraEZ0=; b=gM4RfG+ZqFWYhozyZcTn4BRBjrWrooVDPVOfZ/5iiW5UrT/8EoTR0OdcUFFWPgHi9V BLrBqNiMsnc5BVypXYB/V0o/pbejabM0Hm7caa+rpnafRW8LnI1bqph4KB+mLpofueMu qU8bIQitEfoVr9yKIRbYU7qcaXL5NgrCzFG2PUPYXy5khHKdIyhdjJX842CvVer3RZv2 mvu3mQYdE2hAtLDYe8+yLERi75fH/gFw1UrcG2beBwVvThx0IocCGIUmi0QcIGbErcTA WlvD+I3nFYX1qRVY+Bsb4saWQSf+YUCOenkp4xHDy4YzB1fNG57FXBN3xPWPhW+jf/18 fsRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Y7SHWAiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s145si16998173pgs.228.2019.04.05.02.24.46; Fri, 05 Apr 2019 02:25:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Y7SHWAiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730625AbfDEJXs (ORCPT + 99 others); Fri, 5 Apr 2019 05:23:48 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36508 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730188AbfDEJXs (ORCPT ); Fri, 5 Apr 2019 05:23:48 -0400 Received: by mail-wm1-f65.google.com with SMTP id h18so6387508wml.1; Fri, 05 Apr 2019 02:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N74Gigeamf6uW7mNOcPxG0cICPEw7tgItm/aODraEZ0=; b=Y7SHWAiNIsOj5UiBdsBF+XsixG/mkJwc4EwBvfuVtYNHYLm4c4m863UByTK0ik8zVs 55Y5ewEhVmBlQxCmsbVhNDYygrBarScicFhVaoJ4tGeuSbIj0EbBZ0SAOZvVhbiMwlly 7D0NXLgPrcMP19oKUf1pRSQd9cet0lDjCMGsyLd/1wHwAbfR3+wG8E0hnp6BxnH/1XOV DqVEFhBNQRbOSwugKKpOKONxTTNAXAuU4FSg1C14050qa6sxYC58ak0nIxHfIgihb31f qGdy5MgjJ1JGr0W9Pc/sh9KOhqtpA5I4gl/9e5FY/haKfr9gheeT7o+sBxan6/TUKuzH 3heQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N74Gigeamf6uW7mNOcPxG0cICPEw7tgItm/aODraEZ0=; b=WxijQ0xiPvtSbRkJWNT3MA+NXLDQ7/JjY+bNVYs4yeKd/P9IUSID6uDtvAn+LxJrc6 TeieoBxou1H1GqNw8f4BP99rMDdJmYfbdzwXoODygQ/rHX+OYI5lLfEe94cODPLxDb77 0T0TgFtRzj5OZY/gD651pB3cNKXTHIT30cpc3drtwmrkR7x8dHjLRTsz9heB5bM3GeFH Blb1h+gBwqJjvGrpuyOoYR3gJ3JP/gRj2RMt70AXLFb1EYbhbY1qrLQjlHC+ZyWle5p2 i3snU+v1sNkKI4aOfP84AsFuNuBh7JcCdW/cAxC4ETjgpJQX4008V3rEJHOr6G0EBGXt JS5g== X-Gm-Message-State: APjAAAWMiUF1eYTT3buq7JfePB2/7dyEukJIT1jy/4aHXPJUenfOFQuj qfoZZLeaqKlnF/nshqo9ZVsNRCJS X-Received: by 2002:a1c:9609:: with SMTP id y9mr7435012wmd.27.1554456225949; Fri, 05 Apr 2019 02:23:45 -0700 (PDT) Received: from [192.168.8.147] (69.248.23.93.rev.sfr.net. [93.23.248.69]) by smtp.gmail.com with ESMTPSA id n13sm24747978wrw.67.2019.04.05.02.23.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 02:23:44 -0700 (PDT) Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses To: Lawrence Brakmo , "Tilmans, Olivier (Nokia - BE/Antwerp)" , David Miller Cc: "De Schepper, Koen (Nokia - BE/Antwerp)" , "research@bobbriscoe.net" , "fw@strlen.de" , "borkmann@iogearbox.net" , "ycheng@google.com" , "ncardwell@google.com" , "edumazet@google.com" , "agshew@gmail.com" , "glenn.judd@morganstanley.com" , "kuznet@ms2.inr.ac.ru" , "yoshfuji@linux-ipv6.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190404121731.13917-1-olivier.tilmans@nokia-bell-labs.com> <20190404.105243.1039649838417325989.davem@davemloft.net> <532BB0D8-95C8-4A4D-A73D-3B563909780F@fb.com> <75CDFF88-5632-4A44-A2BF-5725CDDE7DCA@fb.com> From: Eric Dumazet Message-ID: <0e5b047e-8ee1-ee53-cd46-3be70f0d618f@gmail.com> Date: Fri, 5 Apr 2019 02:23:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <75CDFF88-5632-4A44-A2BF-5725CDDE7DCA@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2019 11:55 AM, Lawrence Brakmo wrote: > > The module parameter, even if enabled by default, would have been > preferable since it would support environments where this feature > turned out to be sub-optimal. Module parameters are awful, just add a sysctl if you need. Bonus : per netns thing, meaning writing tests (say with packetdrill) is easier, since you can launch dozens of them in parallel, each one in a different netns.