Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp180735yba; Fri, 5 Apr 2019 04:40:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNeAqEPN7PxsOtFiI36XmNR1z8lpSU52V5pyJ2L6gqrXoleQdy710HmkVGxOBZjE7AUOFf X-Received: by 2002:a17:902:b706:: with SMTP id d6mr12368158pls.250.1554464448904; Fri, 05 Apr 2019 04:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554464448; cv=none; d=google.com; s=arc-20160816; b=XXI+C/uJ5p6WWW1w3Gp7lgDMhSpYBVoVGB1mQjEduAHFyPCrnJbKIK3l7SrBDmMXFW bl1UpEtDOiOC8vek7N1FfFq6G78GfOJX2a2phSM6SJZFaIiuqM+Wyijx+unlZ5YvUC3d 4ovTrdGozt3OH6LwNP6r/IPPDfROHAfELEzsgZxL15V0RIJsLV5zzp59qm99Gthoi2hb M1Nbi7rYdKcOoxYnKvfQeiMYU2y0oY6C89HA90S2TZ2l1CtmhrIesdALzJ7AKxhPLYMx GX7yjNQ6N+G9oSnqqL/0crvO6eM63Dmo3xBgINJJlQfDu+o4606dX+yUQVgPrqiSy4kh i0eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=CdTek4LgKGb9hmagnjJH5xiResgtx7vucmDEAd0e0io=; b=FsH68gN6nU5nhmaMPB2jKIObyuMOAtIUXlKMnjzruRNhx7+hpKXe103wmLjgYPrCz1 ZXgTXEug20Fj6MGOK+FePNQcGuBsC2Z9eiQFE/TrBYKah2/VKqIJUmlPK/28VJgm4K5H ANt9b8gE4a7VY5sqLD/+HitaZ0+Gwznlz+n+CXpVlSQQf9/8MKxZ4gtVj4Yn3APLCJ9a G1HMwBmxaTJXqqtbvNW54Ob96NquAkGDB1exVUrDmkp7SZ5wyzryz4FNByeHeLYv4AIL uop6gTSPHPjJaE67/R+eynYZC8jgQJXj+F7j5zvg+IyLEwv+jdxuSyDzNUrS+2/HRPQK t6hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l40si19512138plb.164.2019.04.05.04.40.33; Fri, 05 Apr 2019 04:40:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731102AbfDELio (ORCPT + 99 others); Fri, 5 Apr 2019 07:38:44 -0400 Received: from terminus.zytor.com ([198.137.202.136]:33621 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730642AbfDELio (ORCPT ); Fri, 5 Apr 2019 07:38:44 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x35BcYjH2734462 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 5 Apr 2019 04:38:35 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x35BcYaG2734459; Fri, 5 Apr 2019 04:38:34 -0700 Date: Fri, 5 Apr 2019 04:38:34 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Andi Kleen Message-ID: Cc: tglx@linutronix.de, hpa@zytor.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, mingo@kernel.org, ak@linux.intel.com Reply-To: mingo@kernel.org, ak@linux.intel.com, acme@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, jolsa@kernel.org, hpa@zytor.com In-Reply-To: <20190326221823.11518-2-andi@firstfloor.org> References: <20190326221823.11518-2-andi@firstfloor.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf stat: Revert checks for duration_time Git-Commit-ID: c2b3c170db610896e4e633cba2135045333811c2 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c2b3c170db610896e4e633cba2135045333811c2 Gitweb: https://git.kernel.org/tip/c2b3c170db610896e4e633cba2135045333811c2 Author: Andi Kleen AuthorDate: Tue, 26 Mar 2019 15:18:20 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 1 Apr 2019 14:49:24 -0300 perf stat: Revert checks for duration_time This reverts e864c5ca145e ("perf stat: Hide internal duration_time counter") but doing it manually since the code has now moved to a different file. The next patch will properly implement duration_time as a full event, so no need to hide it anymore. Signed-off-by: Andi Kleen Acked-by: Jiri Olsa Link: http://lkml.kernel.org/r/20190326221823.11518-2-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/stat-display.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c index 6d043c78f3c2..3324f23c7efc 100644 --- a/tools/perf/util/stat-display.c +++ b/tools/perf/util/stat-display.c @@ -18,11 +18,6 @@ #define CNTR_NOT_SUPPORTED "" #define CNTR_NOT_COUNTED "" -static bool is_duration_time(struct perf_evsel *evsel) -{ - return !strcmp(evsel->name, "duration_time"); -} - static void print_running(struct perf_stat_config *config, u64 run, u64 ena) { @@ -628,9 +623,6 @@ static void print_aggr(struct perf_stat_config *config, ad.id = id = config->aggr_map->map[s]; first = true; evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; - ad.val = ad.ena = ad.run = 0; ad.nr = 0; if (!collect_data(config, counter, aggr_cb, &ad)) @@ -848,8 +840,6 @@ static void print_no_aggr_metric(struct perf_stat_config *config, if (prefix) fputs(prefix, config->output); evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; if (first) { aggr_printout(config, counter, cpu, 0); first = false; @@ -906,8 +896,6 @@ static void print_metric_headers(struct perf_stat_config *config, /* Print metrics headers only */ evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; os.evsel = counter; out.ctx = &os; out.print_metric = print_metric_header; @@ -1136,15 +1124,11 @@ perf_evlist__print_counters(struct perf_evlist *evlist, break; case AGGR_THREAD: evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_aggr_thread(config, _target, counter, prefix); } break; case AGGR_GLOBAL: evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_counter_aggr(config, counter, prefix); } if (metric_only) @@ -1155,8 +1139,6 @@ perf_evlist__print_counters(struct perf_evlist *evlist, print_no_aggr_metric(config, evlist, prefix); else { evlist__for_each_entry(evlist, counter) { - if (is_duration_time(counter)) - continue; print_counter(config, counter, prefix); } }