Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp195835yba; Fri, 5 Apr 2019 05:01:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxarGAeaBotH0qZhBF++qvBcJK7Jbdo7oIukUVUbafRWa0r9bEBMyNU391id2qDYlvrZc4D X-Received: by 2002:a17:902:a511:: with SMTP id s17mr12561190plq.108.1554465690861; Fri, 05 Apr 2019 05:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554465690; cv=none; d=google.com; s=arc-20160816; b=dBEaVE98ZMoU6iT7ytMuKhk2FwIisOExFnEq10eZSEkNDUAVr/w/cqlj6rs3y7dgIT 9V07MU/5gINN/AKaxYYOoQu8EPUOIxqYa72EcMrPivEcXI0yHaRF6sojg2b4/G31O/+q tHdLFGzcT7R5nuAbEd3uHKCTN61KHr+ksRK7cISsHWqcW8PSGi7Kh5HpXJmv17NK7a12 +oEO71LUHpftpzl/7n2r3phXs4M4Lwyicoq0WQYSWg3+6Usjv+B8r/ARlWfM84QoAusM CLIds+STxQOdgWtCcrj06Vw3WDVzSC2i7VjoWV51TQIWNK+ws4dcgMtfecA1MceaXgzv J19A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=s7UMIO3dgQH/d7mTZKuy+c2JSIhfdm3eWaOTTYxfHVA=; b=xgIKvyVGAuyiJBUEBEOsAw/ROFcx54UCU1pEfwbX6TmPI69+oVoMZA4KSU/JpNvIeZ um2af7TBygpDze90sg5hM1ZKJqVX6Hujg+4hdWGoXqgDkLHs1x28es4FDl6xQAJSAeJQ 581Gs5azj2GU6NRzPqNPonKx9c6U/LjNRT/3yYXyRPAOWddfoCdmWKuzbQpg+ySc2yPB YrLuCRhbSGn+fIJL5wSP2i+OreEMaGK3iyqWv4I5leki3+DJ3Ud/C0AV7sSVx+Kfgiya 5VQwwyK/xGVLXsgRK2pv2dV+aLdx33pGmnOFRJWj6l+lOQiEqbChcyIDqoaiw2Q4R/J0 Daew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si18475341plo.36.2019.04.05.05.01.15; Fri, 05 Apr 2019 05:01:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730826AbfDEMA2 (ORCPT + 99 others); Fri, 5 Apr 2019 08:00:28 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48002 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfDEMA2 (ORCPT ); Fri, 5 Apr 2019 08:00:28 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hCNW0-0000JC-IL; Fri, 05 Apr 2019 14:00:12 +0200 Date: Fri, 5 Apr 2019 14:00:11 +0200 (CEST) From: Thomas Gleixner To: Fenghua Yu cc: Ingo Molnar , Borislav Petkov , H Peter Anvin , Dave Hansen , Paolo Bonzini , Ashok Raj , Peter Zijlstra , Kalle Valo , Xiaoyao Li , Michael Chan , Ravi V Shankar , linux-kernel , x86 , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, Xiaoyao Li Subject: Re: [PATCH v6 11/20] kvm/x86: Emulate MSR IA32_CORE_CAPABILITY In-Reply-To: <1554326526-172295-12-git-send-email-fenghua.yu@intel.com> Message-ID: References: <1554326526-172295-1-git-send-email-fenghua.yu@intel.com> <1554326526-172295-12-git-send-email-fenghua.yu@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Apr 2019, Fenghua Yu wrote: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > +u64 kvm_get_core_capability(void) > +{ > + return 0; > +} > +EXPORT_SYMBOL_GPL(kvm_get_core_capability); Why is this global and exported? The only users are in this very file. Thanks, tglx