Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp215031yba; Fri, 5 Apr 2019 05:21:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7UG5pZMj95O3J7ezop2NEZfJ6C8ZADUjhnM2k3k43OKwpboX+/qiuGaK/wZMUtKqfjF9X X-Received: by 2002:a62:e10e:: with SMTP id q14mr11917775pfh.161.1554466917302; Fri, 05 Apr 2019 05:21:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554466917; cv=none; d=google.com; s=arc-20160816; b=QYFMjpiF4eJIJ4BVMFqAjNLwQgOcqrIyXRbYw0nlpvEtYUmU3I5k4TWEwlHMjzLbdM 1o4lT3egzqf5KAuxTEMxC8Ld6sJflajSayJ1EbeEH9ubySGCdnPeH+MGBopUmGXRBkap BSk+wgLYpmmPjcR84LZkDD7eMsrLJZPFZQI360rQ9zX2TrDLeWd44PKveN+pcwGiq4Xp SIj4IsYe6u8cUOHiWwh7xh22rbzfhhn7Q9SMjRtWZ2dSYFdKojCC6pPPSYygVsj1k+cE JATbeCHwbxBNkQSFy2Pl9LMDJsbBy9B4EQJNxLBMpqSyQrkZZ7wQSyco9r890HHva8KU 4wCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=//OJXxWz8hBMyaBYqrFlpfp5djleUrCeAOPVlhD4nDY=; b=pG+iUib77gP5MMxWij1DRkYZ1ixwX616gRHEAByVvjJGnfuO3FHXGdY/iSJSRRNeft Y7I+86JfnHerdjVY2xGw3mK0DgX+dCKnF9jJUta8Hicg5v8rwEWx4UeRGn5w/X5Nn8Aq aZ7q/hg6s+Z9NR38Y112LD0954NwmvnunGAQD0Jfj1j7nDdye+3PeR9KGXibi+bN6ei0 W2+l37OnmaMDex+LWlQjQU7qw6kVWAdOGi1mi6Vi2yTXOMyOInLCfLpaTR6xOP8jI7hX sgkp/CLd1VxPTnYYsWxacwHHWk5SCzFAHaCjSCJa8Sw1P/vx4CZXOCiRHkCfzAmlT0oW MROg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n23si18463936plp.182.2019.04.05.05.21.39; Fri, 05 Apr 2019 05:21:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbfDEMU6 convert rfc822-to-8bit (ORCPT + 99 others); Fri, 5 Apr 2019 08:20:58 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:60765 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728683AbfDEMU5 (ORCPT ); Fri, 5 Apr 2019 08:20:57 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 16145021-1500050 for multiple; Fri, 05 Apr 2019 13:20:44 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Jani Nikula , Janusz Krzysztofik , Joonas Lahtinen , Rodrigo Vivi From: Chris Wilson In-Reply-To: <20190405121331.6524-1-janusz.krzysztofik@linux.intel.com> Cc: David Airlie , Daniel Vetter , michal.wajdeczko@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Janusz Krzysztofik References: <20190405121331.6524-1-janusz.krzysztofik@linux.intel.com> Message-ID: <155446684177.8259.3979238916498240519@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines Date: Fri, 05 Apr 2019 13:20:41 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Janusz Krzysztofik (2019-04-05 13:13:31) > From: Janusz Krzysztofik > > If there are active users of a device during driver unbind, the driver > now panics on non-empty list of free cachelines. This panic is there to say that fini is being called with active contexts, that it is being called too early. Those requests should be cleaned up first, unpinning the contexts and resources, and so letting the timeline be freed. -Chris