Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp224045yba; Fri, 5 Apr 2019 05:33:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdQSqyRwq3sptASTJlwowDlg3wOOAElqjx5MrsdR8XXANyobtZR8oEG1jTc1COxk6Qaq9X X-Received: by 2002:a63:90c3:: with SMTP id a186mr6145000pge.306.1554467600473; Fri, 05 Apr 2019 05:33:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554467600; cv=none; d=google.com; s=arc-20160816; b=fEBamYNIkxRcRNPoeZ8iRvyVrwZVfLAHs4XSXsxxsbqv7kg8UZIzjabyUBlPyo8lnk jGYXY54REMkoF6GpQN7JLTJR5kr9gqiOybJuwu9TXMcKnCx4ml4L0qFQEpxscCjs0F9D l9nDU7BM4gGcAn8oXnap5WNzW6xUn8k9Xo81C//1EMTOu2lVcwlDiPhqoy9mdDgTOCud eutTDSmLY/js8Fb0wVbqj+utF+p1H4Oyk6+tB3GxQhM03KF5uwLh383wFM2MBir6y5n1 I8xKaTij2o3+0shZ5rrUt/CxY3TWtTRfFSoSRkXbXvNvwQNlKGJP36GGKBegAs2T3at3 rjRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WAj13gdaIDjC3imzX3TJQN6GHkpuGfQR2HZLlAmL17Y=; b=BCzO7FK0KKZclpZdVIXfmb/0b+kW6XtHa4yV/sLEFcX41y1oenwVEyvSemp10c7h7W BOvfOsAB+oZCApNLfy70VwY5gxw0J78sbVsvV9Mdg8yZDQI+0ZV2VYHKKSdqJr0WvvTQ L3VeIWUGDv9xWA4kqBhfEaTWmUK4igJprEhgNCc9FIC+i7bIHwOMVjBKam5OVwT71NYG pytI1XzQKusYfnt0A0aqFGLbIZkqL65DXs6ILfbHbQ/eO7mR2JMkWAjU1ht36rnDavc5 XXDt5qEse5i8iogNHpb00MpiDbf8IJ1RMurQ7XjtsGs2j5Lq8SXxpYYk/RirXeaXZbK/ TNtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PlR/mqoX"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si18623776plk.85.2019.04.05.05.33.05; Fri, 05 Apr 2019 05:33:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PlR/mqoX"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729178AbfDEMcY (ORCPT + 99 others); Fri, 5 Apr 2019 08:32:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726806AbfDEMcY (ORCPT ); Fri, 5 Apr 2019 08:32:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E343217D4; Fri, 5 Apr 2019 12:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554467543; bh=Tv42Q/zIsxgIwqtFLpyMDyzOoahqBUNR6njs6Q0g8jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PlR/mqoXQGpaIFRLRm6NtwN3trgdQz2m7Zih9FnVgebkuKP8Wg3ab3gCgTytHKlwf WSg4oQ9G36Lcuvaz1RySoJ2z+AFRzdGWCuCERibkWSlj4XN1Ub6jYKBOBsfvDUYJtY ccx5DGl/WRtT4IXJIyt7EtdQWXvShHvbaP0MHjoY= Date: Fri, 5 Apr 2019 14:32:21 +0200 From: Greg KH To: Chengguang Xu Cc: dan.carpenter@oracle.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] chardev: add additional check for minor range overlap Message-ID: <20190405123221.GD2299@kroah.com> References: <20190405112711.25275-1-cgxu519@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405112711.25275-1-cgxu519@gmx.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 05, 2019 at 07:27:08PM +0800, Chengguang Xu wrote: > Current overlap checking cannot correctly handle > a case which is baseminor < existing baseminor && > baseminor + minorct > existing baseminor + minorct. > > Signed-off-by: Chengguang Xu > --- > v1->v2: > - Split fix and cleanup patches. > - Remove printing minor range in chrdev_show(). What is the difference for v3? And didn't I already take v2 of this series? thanks, greg k-h