Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp224413yba; Fri, 5 Apr 2019 05:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyh0nHMwOwtOUc3RmBiG7kRmOArePdOsXCy9YUCqFqLR7keiVLRPwZNjESKonRnfRI7SxOm X-Received: by 2002:aa7:9294:: with SMTP id j20mr12297482pfa.64.1554467624995; Fri, 05 Apr 2019 05:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554467624; cv=none; d=google.com; s=arc-20160816; b=nWYy15wQcBy0v8S6DC3utA6VbV9n0k0Gcn3/dnSfIZ/0DAFYeHTK2sJQl9ciz03L9L pR8NB6nc4xdq3C0yVMjem43Gu2DswgwJLS8CiZlm/Yt41Vg9ssfG/lgYh6Go747GNcWP hkXYDUN1uJwSB9WyEbapVcLpt6OmD5QULfxabBX+lUqnnxBIwJBh3VO9mQAuNH1K4StN PvBifD2vNp9ON4mPg74PnE+4xHciSqq3wFyv7uU0TzNYllJ0dMu+KZH2J1sB+0b1AUJI ySLsnSHRGiySJCAvR0yCb7QQjnSdmfqMZdv/fvlsEjelyKOSJEZXaUy7dj3Vj1gHVMVF 9BXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=A+tVI6Fpdk3ySCpdxNrGualtZwJ55J99sa3o8GsGasM=; b=NLYx+6GVeQWtcCQTk7srgzSs/FL4sEtt8D7/0uvC6EvNAmk78/KdryU87zgdT8RBJ/ qLmjoroXtM38cmCIxaNnrIts9HZXAg0zrsccE/5XptRiyD0uGShokQm4j+HF0TCR9IbP MHqSH7zjc4c8VkHCP40sp1t6faKs5pIU7D+Gw+pshkZXSJB438hDrYB8A4CTh+AeIYqU Z/j64mcarfKE7yRUKOHXmyy9fg8eW1gKJr0iQh/h3Do0H1PzWt3paWb+zhBuFpM/0ADZ uQ2oc75MOHCRALW6q87EiYtTQ7GHvEBYTkdkOHPzy+G1iyMVRkpRif3RXkJaO+vGInRX V2ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WJcNkx6z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22si18689565pgk.102.2019.04.05.05.33.30; Fri, 05 Apr 2019 05:33:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WJcNkx6z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730626AbfDEMcu (ORCPT + 99 others); Fri, 5 Apr 2019 08:32:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:51578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729820AbfDEMcu (ORCPT ); Fri, 5 Apr 2019 08:32:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D9C6217D4; Fri, 5 Apr 2019 12:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554467569; bh=84+e49qfpIylAjSyF1r9JWmeh5PjwXW4nKe4P0pFARM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WJcNkx6zcahkIhahxvORy0Q6XfXvN4Ww3paNsgl/DZnCEW2I5CTKru/ZGmoYns/Vu ixFcyGHqjrYyCtLtkwC0VcfH/2VVC42pm4o9XVI3ps+LVhCOUDunN6qOww5ClGAo0m IlxlTccN3vNwOiHJ9+8JC25+ytt7OOEacxZpqhho= Date: Fri, 5 Apr 2019 14:32:46 +0200 From: Greg KH To: Chengguang Xu Cc: dan.carpenter@oracle.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] chardev: code cleanup for __register_chrdev_region() Message-ID: <20190405123246.GE2299@kroah.com> References: <20190405112711.25275-1-cgxu519@gmx.com> <20190405112711.25275-3-cgxu519@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405112711.25275-3-cgxu519@gmx.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 05, 2019 at 07:27:10PM +0800, Chengguang Xu wrote: > It's just code cleanup, not functional change. > > Signed-off-by: Chengguang Xu > --- > v1->v2: > - Split fix and cleanup patches. > - Remove printing minor range in chrdev_show(). > > v2->v3: > - Set variable ret to '-EBUSY' before checking minor range overlap. Can you just send the follow-on patch that does the v3 change as I have already taken your series. thanks, greg k-h