Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 5 Apr 2019 05:43:11 -0700
From:   tip-bot for Dan Carpenter <tipbot@zytor.com>
Message-ID: <tip-95c5c618fa4349b2ba13aebeabf71911208dfc5e@git.kernel.org>
Cc:     tglx@linutronix.de, mojha@codeaurora.org, jason@lakedaemon.net,
        marc.zyngier@arm.com, dan.carpenter@oracle.com, hpa@zytor.com,
        mingo@kernel.org, jiaxun.yang@flygoat.com,
        linux-kernel@vger.kernel.org
Reply-To: jiaxun.yang@flygoat.com, linux-kernel@vger.kernel.org,
          mojha@codeaurora.org, jason@lakedaemon.net, marc.zyngier@arm.com,
          tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com,
          dan.carpenter@oracle.com
In-Reply-To: <20190329062136.GQ32613@kadam>
References: <20190329062136.GQ32613@kadam>
To:     linux-tip-commits@vger.kernel.org
Subject: [tip:irq/urgent] irqchip/irq-ls1x: Missing error code in
 ls1x_intc_of_init()
Git-Commit-ID: 95c5c618fa4349b2ba13aebeabf71911208dfc5e
Robot-ID: <tip-bot.git.kernel.org>
Robot-Unsubscribe: Contact <mailto:hpa@kernel.org> to get blacklisted from
 these emails
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Commit-ID:  95c5c618fa4349b2ba13aebeabf71911208dfc5e
Gitweb:     https://git.kernel.org/tip/95c5c618fa4349b2ba13aebeabf71911208dfc5e
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Fri, 29 Mar 2019 09:21:37 +0300
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 5 Apr 2019 14:37:56 +0200

irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()

Currently, when irq_domain_add_linear() fails, the error code does not get
set so it returns zero which is wrong.  Fix it by setting the appropriate
error code.

Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: kernel-janitors@vger.kernel.org
Link: https://lkml.kernel.org/r/20190329062136.GQ32613@kadam

---
 drivers/irqchip/irq-ls1x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 86b72fbd3b45..353111a10413 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
 					     NULL);
 	if (!priv->domain) {
 		pr_err("ls1x-irq: cannot add IRQ domain\n");
+		err = -ENOMEM;
 		goto out_iounmap;
 	}