Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553632152-18888-1-git-send-email-linux@roeck-us.net> <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com>
In-Reply-To: <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 5 Apr 2019 17:45:32 +0300
Message-ID: <CAHp75VfKYCnYdvpvkGgdjXJNRRKWOW-ps99ROWZZSH_NZAOMLg@mail.gmail.com>
Subject: Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
To:     "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@linux.intel.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
        Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
>
>
> On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
> > 0day reports:
> >
> > drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
> >       symbol 'quirk_xtal_ignore' was not declared. Should it be static?
>
> Looks good to me.

Please, give a corresponding tag.
Meanwhile I will apply it to my review and testing queue for robots to
play with, thanks!

>
> > Mark the function static since it is indeed only called locally.
> >
> > Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> > Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >   drivers/platform/x86/intel_pmc_core.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> > index f2c621b55f49..9908d233305e 100644
> > --- a/drivers/platform/x86/intel_pmc_core.c
> > +++ b/drivers/platform/x86/intel_pmc_core.c
> > @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
> >    * the platform BIOS enforces 24Mhx Crystal to shutdown
> >    * before PMC can assert SLP_S0#.
> >    */
> > -int quirk_xtal_ignore(const struct dmi_system_id *id)
> > +static int quirk_xtal_ignore(const struct dmi_system_id *id)
> >   {
> >       struct pmc_dev *pmcdev = &pmc;
> >       u32 value;


-- 
With Best Regards,
Andy Shevchenko