Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
        Vishwanath Somayaji <vishwanath.somayaji@intel.com>,
        Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <1553632152-18888-1-git-send-email-linux@roeck-us.net>
 <4554bd3e-fabb-44aa-fc82-52ec9cbf9b2c@linux.intel.com>
 <CAHp75VfKYCnYdvpvkGgdjXJNRRKWOW-ps99ROWZZSH_NZAOMLg@mail.gmail.com>
From:   "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@linux.intel.com>
Message-ID: <0822b960-be6e-6fcd-fed5-1825d2818b80@linux.intel.com>
Date:   Fri, 5 Apr 2019 20:19:21 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAHp75VfKYCnYdvpvkGgdjXJNRRKWOW-ps99ROWZZSH_NZAOMLg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sending again as i got delivery failure notification from the mailing 
list for some reason.

On 05-Apr-19 8:15 PM, Andy Shevchenko wrote:
> On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh
> <rajneesh.bhardwaj@linux.intel.com> wrote:
>>
>> On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
>>> 0day reports:
>>>
>>> drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
>>>        symbol 'quirk_xtal_ignore' was not declared. Should it be static?
>> Looks good to me.
> Please, give a corresponding tag.
> Meanwhile I will apply it to my review and testing queue for robots to
> play with, thanks!

Sure.

Acked-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>


>>> Mark the function static since it is indeed only called locally.
>>>
>>> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>>> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> ---
>>>    drivers/platform/x86/intel_pmc_core.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
>>> index f2c621b55f49..9908d233305e 100644
>>> --- a/drivers/platform/x86/intel_pmc_core.c
>>> +++ b/drivers/platform/x86/intel_pmc_core.c
>>> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
>>>     * the platform BIOS enforces 24Mhx Crystal to shutdown
>>>     * before PMC can assert SLP_S0#.
>>>     */
>>> -int quirk_xtal_ignore(const struct dmi_system_id *id)
>>> +static int quirk_xtal_ignore(const struct dmi_system_id *id)
>>>    {
>>>        struct pmc_dev *pmcdev = &pmc;
>>>        u32 value;
>
>