Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp451127yba; Fri, 5 Apr 2019 09:50:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAG1Wp68DsdwYphMNpPRbCRN9D25u3hvzsNB+NNgBGEIXhEXnpcQaZYesFc6eDQUWN5fpA X-Received: by 2002:a17:902:e109:: with SMTP id cc9mr14352975plb.148.1554483006353; Fri, 05 Apr 2019 09:50:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554483006; cv=none; d=google.com; s=arc-20160816; b=yZ0eI34olZtoD1ySj8Cutwk0jFN0b9EUrwiWDfnh6O8crScZs56z9mdYWdduRAC+uE W6CRxilr6dtXyVv5hhtpKlE2hWZHQKoQdtoTWBhNEvGqdvPkkts2VaMq2NL87OhN4eas IIrgc6mWf/g0O18Sj23y/GT/YFe6C/huMsyhakRUSk+Lmc8L9+eMhZmOiKKylDMxF9NZ 4Qnn2vKkTRIZI35iEpBtBDQ8PLmVilSLMMz++6O20Q8xk6cy7i/8omjM+dWhmKcN78p5 OLoaPL8gZYurzp6yJ45v7n3Md5RXjN2ODMMV7XniSOWlQD0bkLr1qK6DUoAsIDfy4Mn2 0KuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=OClJwWLjqpoj5Wd9XwtSYhC8f7C/LPDexr+hLQZqvFE=; b=QRDoYSMdsY7uLnpyhodTpSdDoOobCIeVhi5V1fooP/g93UF0YXh5P0ysdYy1ml4pyv B7Kw/J2XTcl8iKEUgY7vE1gTY7HZiW4t4jdLYMumMf9lnKqVmKU1dpBU2cxNH+JsXQd1 LMOgBcyHkafgdcj568diNohFUyGpZvCNCWf0um7p29PkXU7zNneqnWVMiPlUKRjDPljj 3zYjw6C9QhQfPKRCu4l2G4PkLqBo8gw0fkVTAWC0eGYeeEi59Xmg9cn7sPImoyiWqSJ2 AJY5smpZFwHuPwkOXRE7IbR6pqaOSCa8FvEXqEKEp/sgC8zsV9mxbIS2I4TulBfH35gw BIjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t26si18954717pgu.504.2019.04.05.09.49.50; Fri, 05 Apr 2019 09:50:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731313AbfDEQru (ORCPT + 99 others); Fri, 5 Apr 2019 12:47:50 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:40164 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730565AbfDEQru (ORCPT ); Fri, 5 Apr 2019 12:47:50 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1hCS0I-0006wh-IS; Fri, 05 Apr 2019 18:47:46 +0200 Date: Fri, 5 Apr 2019 18:47:46 +0200 From: Florian Westphal To: Jeffrin Jose T Cc: fw@strlen.de, shuah@kernel.org, pablo@netfilter.org, linu-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests : netfilter: Wrote a error and exit code for a command which needed veth kernel module. Message-ID: <20190405164746.pfc6wxj4nrynjma4@breakpoint.cc> References: <20190405163126.7278-1-jeffrin@rajagiritech.edu.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405163126.7278-1-jeffrin@rajagiritech.edu.in> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffrin Jose T wrote: > A test for the basic NAT functionality uses ip command which > needs veth device.There is a condition where the kernel support > for veth is not compiled into the kernel and the test script > breaks.This patch contains code for reasonable error display > and correct code exit. Looks good to me, thanks for following up on this. Acked-by: Florian Westphal