Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] um: Do not unlock mutex that is not hold.
To:     Daniel Walter <dwalter@google.com>, richard@nod.at,
        linux-um@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org
References: <20190402084332.88965-1-dwalter@google.com>
From:   Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Message-ID: <cb5e35f0-9f95-fec1-9325-be8fa580bf00@kot-begemot.co.uk>
Date:   Fri, 5 Apr 2019 17:17:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190402084332.88965-1-dwalter@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 02/04/2019 09:43, Daniel Walter wrote:
>   Return error instead of trying to unlock a mutex that is not hold.
> 
> Signed-off-by: Daniel Walter <dwalter@google.com>
> ---
>   arch/um/drivers/ubd_kern.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
> index aca09be2373e..33c1cd6a12ac 100644
> --- a/arch/um/drivers/ubd_kern.c
> +++ b/arch/um/drivers/ubd_kern.c
> @@ -276,14 +276,14 @@ static int ubd_setup_common(char *str, int *index_out, char **error_out)
>   		str++;
>   		if(!strcmp(str, "sync")){
>   			global_openflags = of_sync(global_openflags);
> -			goto out1;
> +			return err;
>   		}
>   
>   		err = -EINVAL;
>   		major = simple_strtoul(str, &end, 0);
>   		if((*end != '\0') || (end == str)){
>   			*error_out = "Didn't parse major number";
> -			goto out1;
> +			return err;
>   		}
>   
>   		mutex_lock(&ubd_lock);
> 

Reviewed-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>

-- 
Anton R. Ivanov
https://www.kot-begemot.co.uk/