Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp507791yba; Fri, 5 Apr 2019 10:59:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+SG0h0sQ/hhv/NtyupkagqBQ126z7bVY0VDy1BHmiQKHbvmOHIdD8BQxhAIIj/HVOX4OY X-Received: by 2002:a65:6091:: with SMTP id t17mr13478291pgu.328.1554487193991; Fri, 05 Apr 2019 10:59:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554487193; cv=none; d=google.com; s=arc-20160816; b=hCebnvzdYIz8eCD8ZkJCb4hEmmoSJV/GwbQGAQd5qLqtP0OlBo45ksP8FUhZFNzxe3 /MyOYY1G3CcTPTqMfNzg1nI8ZdLBH52eK2zDphPfKDTNV/G3PLQ5eR5kOFmfc70Ijt11 AVdoAudI3+ta2I5+YJ0B8ptwfPYsTldUuagm4hD1Hp64Qd8PUuelRbL+/M6y7HqWRcZp R+MJv50TTc5hPa8LIu98HcFrGu/34P9mWBdoZXWTaPllb+qRHI9hIlSMEKlIG9KAQIOr pt346JRbmSWY64b1GBW2rs3yG9Ar9ZfSIYJl3ivHFGJS3CK+LJVMFMm+5J/cNFQS6P7N edCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:cc:to:subject:from:date:dkim-signature; bh=5XQVS7t9m90qdPGpy4MI72WNqmJlj0KlB6QjPVJbtik=; b=guxFWsHOKwhG+ItRizRO9nCct8c2L5d4fiyeYKBBFcme65UNui9psdi0smMpWvOJFf 0Y7seHDktUaZL6+oJ6XfGFL7j1XFlCIlJ2AeBYE2B3Wh738oXryvVdTlzUiRCBqFRb9g 048loJQW5a923hZHz5xZiwGxRzr/jZNIzIdtiVk7ZK6W6iby6co2aGjBGNFnZFhNDuhR +MCcTzuWF4RAITkuh5z8eJv5qdT/msiGawhuAsHRCUX/o60zh0I1iYL9F2yq5pjhbrvU DXHEZZEKMlCeeEvqGkZGOJVeei1Ei78Zv98JtmXdOJIm4jP9jbDxlAiuyFalOMg1giO5 ccfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J5RFetQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si18769803pgs.503.2019.04.05.10.59.38; Fri, 05 Apr 2019 10:59:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J5RFetQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731637AbfDER64 (ORCPT + 99 others); Fri, 5 Apr 2019 13:58:56 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:37075 "EHLO mail-wr1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbfDER64 (ORCPT ); Fri, 5 Apr 2019 13:58:56 -0400 Received: by mail-wr1-f44.google.com with SMTP id w10so9044399wrm.4; Fri, 05 Apr 2019 10:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=5XQVS7t9m90qdPGpy4MI72WNqmJlj0KlB6QjPVJbtik=; b=J5RFetQe9mWtcazqoTkqbDlgl1dulNZGqjluyuRxf9e857Q+3HO2jORVv4djfLq2+9 FOsNap9hHQQ2/t0/mi1NEscqXl7fC7japUQ+dAaP2r9d51ZQs+zIRrEJmnrP4a8yRQZ8 PHN+8Fi+ST/oo6igY2T712C9cIMlT5ETAysUnd2UrX554EeYmBgyBUNRwo2koFhHjnen 2LlolljrjMGRq5CM+YwW8J1o6UxanY8JffXuPtjRFqgbGYtgmAGC9t3aaN4aC6LSSPg0 lqZfnNlunQBUecorb4JFy7f52JMjgLuwQmNvLM2gJFFbnRabyfEQWiPVFKfZrBKAqF8L UxTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=5XQVS7t9m90qdPGpy4MI72WNqmJlj0KlB6QjPVJbtik=; b=Bn4JEJ08i28eh/CT4HRndSlwG1gGyaID0GOuOIzVxj4xUYIo+N/pLRtz6CP1Fowt+I r6as47SJQl1Ropk0n6sCgormkln4lz9dJrsXG8evmvVcUWztSKRMenDWYhR8LVQvYuSW meJPRQrj/EjKOrSTrp4zMC/hMTcuTep+ajsDslHL9phCiYBa7nJPLsnZ5+cz4Nm3AKbH FLGLSN6QSUxyBDfrY8OMmWptdyaMu59Rb6zHGZ69/uXtivZqXwAstxNv7F7jEwVNUtK3 d50+LAQO3DY97/+qJGOh99kTp9HTTXx3F7PGYddXbquthr6me+ANURlsKh5FlJhZyAwO e4SA== X-Gm-Message-State: APjAAAVSkcQRZQfBng65mY+m2eAkVq0SNhtKTqGJS/qwVzXI/uxht7Vu kvAEpFXKBuGfOdIGMWjLDORD52dvNNAKtw== X-Received: by 2002:a5d:4c88:: with SMTP id z8mr9186221wrs.291.1554487134218; Fri, 05 Apr 2019 10:58:54 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:9cd8:5174:23da:3e1d]) by smtp.gmail.com with ESMTPSA id o4sm5325874wmo.20.2019.04.05.10.58.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 10:58:53 -0700 (PDT) Date: Fri, 05 Apr 2019 20:58:49 +0300 From: "Leonidas P. Papadakos" Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Jose Abreu Cc: Robin Murphy , Philipp Tomsich , Heiko =?iso-8859-1?q?St=FCbner?= , Christoph =?iso-8859-1?q?M=FCllner?= , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, LKML , Linux ARM , Klaus Goger Message-Id: <1554487129.1193.0@gmail.com> In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B44985F@DE02WEMBXB.internal.synopsys.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> <1554305721.1328.0@gmail.com> <1554306954.1328.1@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B44985F@DE02WEMBXB.internal.synopsys.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > You can play around different PBL values without using the no-pbl-x8 > option. > > I would start with PBL=0x1 and then going up. If PBL=0x1 does not > work then > add the no-pbl-x8 option and start with PBL=0x20 and keep decreasing. > > Thanks, > Jose Miguel Abreu > Okay, so setting snps,txpbl = <0x1>; seems to work. Is that our best value or do higher values yield better performance?