Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp539930yba; Fri, 5 Apr 2019 11:39:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXk3u16V8LpRVCSPhs4KJuPWH+SBC2XSwNFlXDPhiSLzv23xVay9kw4uCOLhiFU+zPSAI6 X-Received: by 2002:a65:638f:: with SMTP id h15mr10165637pgv.147.1554489599223; Fri, 05 Apr 2019 11:39:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554489599; cv=none; d=google.com; s=arc-20160816; b=Kw7LlmX5RWQrDVzFpz1styDGGB0nuDt1aoP/C2lJi2WDXxTH7z8cAOw2DQ9KxJaKZp bLDz9yGdlSjrbZpps0Faxz6LrmJCnPlkKkHjSjtYyEtfC1Y7BPAR33Ni7iz1+qVXTzfY arOtquuUkh2obyCUoSC/8XxOhKdVoH5oBp++noj0AJCAQ59lgaaJZqjDKoqgGjlYRn8Q H5zaA+sCToTnt2w6tsuSRqJgx8T1D/7e0N0QB80r0LwHuWP8GjkNvu6slPlPsmtlhiEk u1YpVj4SKERxE0/0621neubZeHS4mvaN9rUxGsFeJVxc2uxhOynj4/+Wvwdgd60KSi7e bxMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:cc:to:subject:from:date:dkim-signature; bh=mnvm+9lesrHyZqhSf2DoFjOXCqh3DHNocnRafDoBvnU=; b=C0VWQTfs0D2GyQkV1fhY/itD5od9w93S9kqSKMaRJlxay0KeIGf6J+MbZfFvYUzopQ lBrQNPWEowiuaW3c7wwnQPXFIIdk43w+Mn7en52c2PZ/jNmkXbIVXExTsIau5m/bBmVq XD60WnfY2DKAknqnW+HpjVfhvMWXCfPWAcoddfui0PGeZlGUsKYLh2DXCG3H1cr7Ar7n rXarBh6pOq0Z7QjzBA2SXAsjqgZb1qByhrJt8rir/bdqo6TKiwO8oycM+OinZU86+I35 TRF1yw3y1z8Tq3YUno47spZzJvyLZq36qjpbVC/ueTgmay1tqwCGb3N7GrJnSZXhrV2p YASQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fW+DzFqF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t66si20194394pfb.178.2019.04.05.11.39.43; Fri, 05 Apr 2019 11:39:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fW+DzFqF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731715AbfDESjE (ORCPT + 99 others); Fri, 5 Apr 2019 14:39:04 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51164 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731654AbfDESjE (ORCPT ); Fri, 5 Apr 2019 14:39:04 -0400 Received: by mail-wm1-f65.google.com with SMTP id z11so7787358wmi.0; Fri, 05 Apr 2019 11:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=mnvm+9lesrHyZqhSf2DoFjOXCqh3DHNocnRafDoBvnU=; b=fW+DzFqFbD0upjz5OkgEDADjshaXIn/BqDQfjGmGCp0SyMyNq+tUgh1wDQOQQJOCAv ux5g8dkXO1zIXUoYYPvYXWM4PcldnpGN4qZnGDK1fimCYWf4O0QWDPNa+l43Sg3SeFRp vSSxUk49v7w6uFirCi69WEk9bkSUiqHH2nSAqcI2VAznXYI3fsrnv6Cw2QZT2cpHonxf ocCqGdPdmGzAS/9cLCyfXo3bO2U6zilGt6h01b0CWidL+mShhd53LNE45cEokGdfutlW iH6wDl5q8kYPoUL8ITA5Aa+Yv8nWJePWTwduUQsnnH8EVDyZhvwg9jU2JU+9cfgTloxd 9CaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=mnvm+9lesrHyZqhSf2DoFjOXCqh3DHNocnRafDoBvnU=; b=iVnI2Eq5BspUtHNv3cWAgmggRAg9pGeJxwRJQsVp2ZRzmoOUJK+1zyU5Y44Yf3ieBz hSyQTmcUj5OPtvCjxEHAacdHg7bmsvhzsxucRzgvI+6Vm6tW3qdqhQ9bF3gX3NgiGnAl D23uxyd/qlU8h31Ls9JTfBU9xoo5esKMGaMJshMyWkBfnITQ6c2BUVaBeQMPabRrh69G HxwU7yYhKM4f3V6JD4IsVhvvHNXShNMmTObGI44ZwQoz+H6b1A4p7qCfUh8wi4bLIbBk PzRvnuSU1+ShpkjxunFFEeveP4ATBL3/ldJi2lrfHug+3sVodBW0Buf05gfuCdKk8Rta fQtg== X-Gm-Message-State: APjAAAXfUz9ltdOdGk/1gxJ7j6sBU82Pu8KWZrVAlRAScVwqpDlfu3au GTRPtNxXUNi+s/KR0ZEoZaU= X-Received: by 2002:a1c:9cd1:: with SMTP id f200mr9086912wme.91.1554489542281; Fri, 05 Apr 2019 11:39:02 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:9cd8:5174:23da:3e1d]) by smtp.gmail.com with ESMTPSA id z13sm30968302wrw.36.2019.04.05.11.38.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 11:39:01 -0700 (PDT) Date: Fri, 05 Apr 2019 21:38:57 +0300 From: "Leonidas P. Papadakos" Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Robin Murphy Cc: Jose Abreu , Philipp Tomsich , Heiko =?iso-8859-1?q?St=FCbner?= , Christoph =?iso-8859-1?q?M=FCllner?= , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, LKML , Linux ARM , Klaus Goger Message-Id: <1554489537.1199.0@gmail.com> In-Reply-To: <85c1d945-d49b-3350-6ff4-a058c5a8c1d7@arm.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> <1554305721.1328.0@gmail.com> <1554306954.1328.1@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B44985F@DE02WEMBXB.internal.synopsys.com> <1554488052.1193.1@gmail.com> <85c1d945-d49b-3350-6ff4-a058c5a8c1d7@arm.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > What's your overall setup? So far with my RK3328 box I've found that > with an IPv4 link and an MTU of 2000 I have to dial PBL right down to > 1 or 2 (with no-pbl-x8 as well) to prevent Tx stalling, and with the > MTU bumped up to 3000 it just won't play at any PBL setting... > > Robin. I'm using a Libre Computer Renegade with RK3328 SoC(maybe it's a board specific thing?) I'm using txpbl as from what I can gather, the rx has no issues, no need to change it. When it comes to rx, running the server (iperf3 -s) on the Renegade and iperf3 -c on my laptop, I get about 940 Mbps. It's always been like that, satisfactory. When it comes to tx (the one all the fuss is about) I eventually find that just with snps,txpbl = <0x21>, and no other pbl thing set I get about 905 Mbps on average sent to my laptop, now running the iperf3 server. I must say I haven't touched the MTUs but I never needed to as the issue presented itself in normal usage. Simple iperf tests will fail after same kilobytes if no tweaks are applied.