Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 5 Apr 2019 23:13:57 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Jian-Hong Pan <jian-hong@endlessm.com>
cc:     Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, linux-kernel@vger.kernel.org, linux@endlessm.com,
        Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate
 X514-51T
In-Reply-To: <20190401073514.2785-1-jian-hong@endlessm.com>
Message-ID: <alpine.DEB.2.21.1904052311370.1802@nanos.tec.linutronix.de>
References: <20190401073514.2785-1-jian-hong@endlessm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 1 Apr 2019, Jian-Hong Pan wrote:
> +/*
> + * Some machines require the "reboot=e" commandline options
> + */
> +static int __init set_efi_reboot(const struct dmi_system_id *d)
> +{
> +	if (reboot_type != BOOT_EFI) {
> +		reboot_type = BOOT_EFI;

So if EFI is disabled in the kernel this will fall through to BOOT_BIOS. Is
that intended behaviour?

> +		pr_info("%s series board detected. Selecting %s-method for reboot.\n",
> +			d->ident, "EFI");

Is thee a reason not to write "EFI" in the string itself?

Thanks,

	tglx