Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 6 Apr 2019 10:20:36 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     Slavomir Kaslev <kaslevs@vmware.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: Re: [PATCH 5.0 047/246] fs: Make splice() and tee() take into
 account O_NONBLOCK flag on pipes
Message-ID: <20190406142036.GD2935@sasha-vm>
References: <20190404084619.236418459@linuxfoundation.org>
 <20190404084620.671108728@linuxfoundation.org>
 <3fa8b886ccb1ea2229344091be9ac769021f69a4.camel@vmware.com>
 <20190404173200.GB29613@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20190404173200.GB29613@kroah.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 04, 2019 at 07:32:00PM +0200, gregkh@linuxfoundation.org wrote:
>On Thu, Apr 04, 2019 at 04:16:57PM +0000, Slavomir Kaslev wrote:
>> On Thu, 2019-04-04 at 10:45 +0200, Greg Kroah-Hartman wrote:
>> > 5.0-stable review patch.  If anyone has any objections, please let me
>> > know.
>> >
>> > ------------------
>> >
>> > [ Upstream commit ee5e001196d1345b8fee25925ff5f1d67936081e ]
>> >
>> > The current implementation of splice() and tee() ignores O_NONBLOCK
>> > set
>> > on pipe file descriptors and checks only the SPLICE_F_NONBLOCK flag
>> > for
>> > blocking on pipe arguments.  This is inconsistent since splice()-ing
>> > from/to non-pipe file descriptors does take O_NONBLOCK into
>> > consideration.
>> >
>> > Fix this by promoting O_NONBLOCK, when set on a pipe, to
>> > SPLICE_F_NONBLOCK.
>>
>> [...]
>>
>> > This change does have potential of breaking users who don't expect
>> > EAGAIN from splice() when SPLICE_F_NONBLOCK is not set.  OTOH
>> > programs
>> > that set O_NONBLOCK and don't anticipate EAGAIN are arguably
>> > buggy[2].
>>
>> Hi Greg,
>>
>> Can you drop this one from the stable queues? We discussed it with
>> Sasha[1] already in the autosel patches thread.
>>
>> [1] https://lkml.org/lkml/2019/4/3/811
>
>Dropped from everywhere now.
>
>Sasha, how did this still get in?

Sorry about that, I dropped it from the wrong local branch :(

--
Thanks,
Sasha