Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1291533yba; Sat, 6 Apr 2019 08:24:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqymJkk3258fzGc0viVwj7P9LmpuxgRadjGSOpjuuSeCbTomtnPLr9JV5dAH4ytIs6sqMrva X-Received: by 2002:a65:64cf:: with SMTP id t15mr17856168pgv.322.1554564249759; Sat, 06 Apr 2019 08:24:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554564249; cv=none; d=google.com; s=arc-20160816; b=iwfuZzmO+gBT5Zfr0gTJSEPHqcl2AypGPMLDzWRQX8/Oz4KTvjIWkJLFOP0lg+36Sl GjnahlBuLNaRjXLxXtSdxjw5mruOX/fFsk3XgTW/hjUsaIb3xyidelEZZBnRMBS//Fel cEu9wZ4kuI4nnivPZMk7HrlStjKy5JVj+/VMBUzeWboPwjmMw0u6DYB/mLHECZlvrwlg l/765p8BfXXN4bjpHkU4J+8in5pcYm0SW96/sKOugLGPt1jfwiIcxqy01hREgvhjOenE dHrUZ+ftjX3rt3g2G3dJGfLc6YoGV3AGHZnvXGN8wLzjV7I7xvYlawbWmsFXK4dLiEXj dZdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=01E/WK89uRC/W4dQarwjsNrWMmOUeq1oYfNVHNF+bkQ=; b=Z4E7q/PybUvUmGltv+L6QecQpF4sv3mRLp7163vqUk5sZVHg9TBysxcZeP0apOHvUu 78Qe/VxuHGSGE8C81fxogWUP4Z6R5NDMXIyBYCST/fQbW3JOt9bGEm055EvnJcLEkKkp 5DZmXs1uUGpMA5ODEBHxYOzy3zRutENy0Kc9ji0X8SL7tHuigniObWZF10bpCV6K/om9 AX1x4V3y1cdkS5BRiK3ba6pDuTt976dy33/IyZXMgWYgVVvyUSoO+opGRWngkitQfN13 tH21xGtxox2lFadKH0YhSfxIUIVgvSl4x2VF6hQkEsuVIrfWomgrsxFvoi1o4Xen3bTG DO2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 133si23069839pfu.82.2019.04.06.08.23.54; Sat, 06 Apr 2019 08:24:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbfDFPW0 (ORCPT + 99 others); Sat, 6 Apr 2019 11:22:26 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:51181 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfDFPW0 (ORCPT ); Sat, 6 Apr 2019 11:22:26 -0400 Received: from mx04.mta.xmission.com ([166.70.13.214]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hCn5N-0006AA-Ny; Sat, 06 Apr 2019 09:18:25 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx04.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1hCn5M-0006jx-IA; Sat, 06 Apr 2019 09:18:25 -0600 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id A52541BF139; Sat, 6 Apr 2019 15:18:23 +0000 (UTC) Date: Sat, 6 Apr 2019 11:18:16 -0400 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190406151816.GB10294@hacktheplanet> References: <1550103368-4605-1-git-send-email-zub@linux.fjfi.cvut.cz> <1550103368-4605-5-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550103368-4605-5-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1hCn5M-0006jx-IA;;;mid=<20190406151816.GB10294@hacktheplanet>;;;hst=mx04.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,XMNoVowels,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_UncommonTLD01 Less-common TLD * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 937 ms - load_scoreonly_sql: 0.10 (0.0%), signal_user_changed: 3.3 (0.4%), b_tie_ro: 2.2 (0.2%), parse: 1.16 (0.1%), extract_message_metadata: 18 (2.0%), get_uri_detail_list: 1.32 (0.1%), tests_pri_-1000: 22 (2.3%), tests_pri_-950: 1.32 (0.1%), tests_pri_-900: 1.09 (0.1%), tests_pri_-90: 20 (2.1%), check_bayes: 18 (2.0%), b_tokenize: 5 (0.5%), b_tok_get_all: 4.7 (0.5%), b_comp_prob: 1.57 (0.2%), b_tok_touch_all: 3.7 (0.4%), b_finish: 2.0 (0.2%), tests_pri_0: 133 (14.2%), check_dkim_signature: 0.56 (0.1%), check_dkim_adsp: 2.3 (0.2%), poll_dns_idle: 715 (76.3%), tests_pri_10: 2.2 (0.2%), tests_pri_500: 732 (78.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 04/16] block: sed-opal: unify space check in add_token_* X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 01:15:56AM +0100, David Kozub wrote: > From: Jonas Rabenstein > > All add_token_* functions have a common set of conditions that have to > be checked. Use a common function for those checks in order to avoid > different behaviour as well as code duplication. > > Co-authored-by: David Kozub > Signed-off-by: Jonas Rabenstein > Signed-off-by: David Kozub Reviewed-by: Scott Bauer