Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1302131yba; Sat, 6 Apr 2019 08:40:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzIK+4MygnC2zjfdzfPplHPmGcgrcN6DdO9sLxug5RfIYcsug9jgG+mtrTDTIRRcvsUJ5HV X-Received: by 2002:a63:e10b:: with SMTP id z11mr18282928pgh.46.1554565201303; Sat, 06 Apr 2019 08:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554565201; cv=none; d=google.com; s=arc-20160816; b=bVoBZCvO0zLkVRLAUU2AZez5+aEJiTqW2gLOg6NO1YxRehrZO25OODxieShLKEMXvE A/7SjQpxUfMFZjOy/NOqMF6OZ3sqbkzwhQPevgRqNZzyyDfqS+D8ZForMMyhYw5waQVa qKm25BvcQRpYtmE4k6pqCDr46eKkj5sBOoMz9QmCJ9Ko3mtMNsAtwAvDVzpg4InAUkeU OXnH9U/W2BtKrF6qy4o8Z6zOh6+KRuLLie7SN/ZOvO2rJdHOrOJ27ziqGAav/FNdP+se uQgIGeky8OYyt3KKwxr91nqCduAiWC6dq+MKGevIWvCM8ZQ3yFgRhLfaSYm6+m+kDX3v uuZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=XP3uaQL0+z8gT1Lb8B3ttAv2XwH3Ik08OSJU6WXP1yA=; b=Qu1R/UpaBwoDd1Jb7Q7LRfL7huxmsmxsPUsipvWjNnRv10wYM4u8/YTiTdttngfHNU tdobW38ysKbQ55EvS7cupaLIJLrDqTdNGSD9X93re5vWCHcMYENO5U8puuQgjj7j0Tq3 Ke/46sVgqWzeuyCuOo3+SQX1CmQZHDRAbGY0h7APNJBCmJAV8cr9i1++NJMb+sNKct27 wqVWFSi9/GCA11mao73mLmGQupINi9O7Jp+7OG6hy0f+HLKuEaJJ+wBZUk72ekeTSYBB taXyPlE/AKfwX9faFd15yCzEGr0neJ3ZhTOh9jcmkjJKF2UgqMMkEZEHoi/MvJy85woA iQng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si20992590pgp.446.2019.04.06.08.39.45; Sat, 06 Apr 2019 08:40:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbfDFPhs (ORCPT + 99 others); Sat, 6 Apr 2019 11:37:48 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:52475 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbfDFPhr (ORCPT ); Sat, 6 Apr 2019 11:37:47 -0400 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hCn64-0006DR-ED; Sat, 06 Apr 2019 09:19:08 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1hCn63-0002ff-Ug; Sat, 06 Apr 2019 09:19:08 -0600 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id 2DEA21BF17F; Sat, 6 Apr 2019 15:19:07 +0000 (UTC) Date: Sat, 6 Apr 2019 11:19:00 -0400 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190406151900.GC10294@hacktheplanet> References: <1550103368-4605-1-git-send-email-zub@linux.fjfi.cvut.cz> <1550103368-4605-5-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550103368-4605-5-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1hCn63-0002ff-Ug;;;mid=<20190406151900.GC10294@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,XMNoVowels,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=2 Fuz1=2 Fuz2=2] * 0.5 XM_UncommonTLD01 Less-common TLD * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=2 Fuz1=2 Fuz2=2 X-Spam-Combo: **;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 236 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.4 (1.0%), b_tie_ro: 1.69 (0.7%), parse: 0.82 (0.3%), extract_message_metadata: 14 (6.1%), get_uri_detail_list: 0.87 (0.4%), tests_pri_-1000: 35 (14.8%), tests_pri_-950: 1.47 (0.6%), tests_pri_-900: 1.17 (0.5%), tests_pri_-90: 18 (7.6%), check_bayes: 16 (6.9%), b_tokenize: 5 (2.3%), b_tok_get_all: 4.8 (2.0%), b_comp_prob: 1.64 (0.7%), b_tok_touch_all: 2.4 (1.0%), b_finish: 0.69 (0.3%), tests_pri_0: 143 (60.8%), check_dkim_signature: 0.64 (0.3%), check_dkim_adsp: 2.4 (1.0%), poll_dns_idle: 0.61 (0.3%), tests_pri_10: 2.2 (0.9%), tests_pri_500: 10 (4.4%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 04/16] block: sed-opal: unify space check in add_token_* X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 01:15:56AM +0100, David Kozub wrote: > From: Jonas Rabenstein > > All add_token_* functions have a common set of conditions that have to > be checked. Use a common function for those checks in order to avoid > different behaviour as well as code duplication. > > Co-authored-by: David Kozub > Signed-off-by: Jonas Rabenstein > Signed-off-by: David Kozub Reviewed-by: Scott Bauer