Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1307698yba; Sat, 6 Apr 2019 08:49:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqydGgMH7yrZRXI5SfmpzHHZcW0WkjDPRZBekS311lh8zr55CikBBvQDIrvF9Z6QVw2SV64F X-Received: by 2002:a62:1c07:: with SMTP id c7mr19320413pfc.159.1554565790274; Sat, 06 Apr 2019 08:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554565790; cv=none; d=google.com; s=arc-20160816; b=l2/AJxB7vOFjwyFwIB/F/vIRjRnqjrFjY5OCz6h02pIYYSKGT6FsbY+Qn7CijXPaIO PgC3P8cOq5qdI23CngEClhjZQsVVMMs9DR8aBPkix1NIlKwGelC3LPtew0ydJMCTPmPQ zG39Zb6hIavrmfMHpdXokCtl/c+7hvlS+Bh3oGNjihEjRErJCJ+E7A1RnQkEbLmBFyZs dwOSED/WOphF5cPcqbCSEvGKswc0byx0ncgOqPWdA83TVSfBdgOJHDK6J53VCQvKNT7f meV669Md1h4SHDi4SHABrMStj05VNBW7M9cTmPf0Nv6zCR8yTirH2BxKnpbwtZ9J6CqT VNTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=624LoASW0bkbuVroNq5Eu2A3HbkSmaDWpawx1Hx6eyE=; b=KYNpG4qeez0MyfIU9Z7iFTce80mhNGITubtbBUSo4iOdM8gZJDgyxLB5ztBaWK+Gyq vMihBMdynRd7rf5eu16DMZ+eEFQIXBTLc/FqhShubiQuMEh9aZN6gCtQfb6R78VVZBdc v3l4q9rfo4YSHp+jtU01j/mlTugHtRkU4FhJyWnx3zApEc4ZSQqjPCnswYMSHxUk8IUG CagWLeYrvGXv8MNV5QFIK23MvoSi5BalQ/MCC2sVy1mJLuVuL5bo/k4y9rrMAUy17JJs WW0g3zko41B0GfT/HzF+BEtOmQGBbixAB/p53JBOf6SC2krvS6Dj+Timo2L+jW1j9Th4 GT8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si22650960plj.417.2019.04.06.08.49.33; Sat, 06 Apr 2019 08:49:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbfDFPsz (ORCPT + 99 others); Sat, 6 Apr 2019 11:48:55 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:32843 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbfDFPsz (ORCPT ); Sat, 6 Apr 2019 11:48:55 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hCnYm-00058y-K1; Sat, 06 Apr 2019 17:48:48 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hCnYl-0005GM-57; Sat, 06 Apr 2019 17:48:47 +0200 Date: Sat, 6 Apr 2019 17:48:47 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Wolfram Sang Cc: laurentiu.tudor@nxp.com, mojha@codeaurora.org, linux-i2c@vger.kernel.org, wsa+renesas@sang-engineering.com, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com Subject: Re: [PATCH v2] i2c: imx: don't leak the i2c adapter on error Message-ID: <20190406154847.gknmrvjzebih3tu5@pengutronix.de> References: <20190401101437.9626-1-laurentiu.tudor@nxp.com> <20190403204756.mbc7zc5klfd5zydg@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190403204756.mbc7zc5klfd5zydg@ninjato> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Wolfram, On Wed, Apr 03, 2019 at 10:47:56PM +0200, Wolfram Sang wrote: > On Mon, Apr 01, 2019 at 01:14:37PM +0300, laurentiu.tudor@nxp.com wrote: > > From: Laurentiu Tudor > > > > Make sure to free the i2c adapter on the error exit path. > > > > Signed-off-by: Laurentiu Tudor > > Reviewed-by: Mukesh Ojha > > Reviewed-by: Uwe Kleine-Konig > > Fixes: e1ab9a468e3b ("i2c: imx: improve the error handling in i2c_imx_dma_request()") > > Applied to for-current, thanks! Is your tree already stable? If not, would you mind correcting my name in 9b0a9982d8b465e0394db10f15ba53f1a8d60e21? Best regards and thanks in advance from Freiburg Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |