Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EA29560A42
Subject: Re: [PATCH] kernel: pid_namespace : fix warning Using plain integer
 as NULL pointer
To:     Hariprasad Kelam <hariprasad.kelam@gmail.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
References: <20190406104828.GA26135@hari-Inspiron-1545>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <9af19729-cd8a-c3ec-6e89-1696f338c5c1@codeaurora.org>
Date:   Sun, 7 Apr 2019 00:42:56 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190406104828.GA26135@hari-Inspiron-1545>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/6/2019 4:18 PM, Hariprasad Kelam wrote:
> changed passing function argument "0 to NULL" to fix below sparse
> warning
>
> kernel/pid_namespace.c:55:76: warning: Using plain integer as NULL
> pointer
>
> did changes to avoid checkpatch error "prefer a maximum 75 chars per
> line"
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   kernel/pid_namespace.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index aa6e72f..6e4afdc 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -52,7 +52,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level)
>   	mutex_lock(&pid_caches_mutex);
>   	/* Name collision forces to do allocation under mutex. */
>   	if (!*pkc)
> -		*pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0);
> +		*pkc =
> +		    kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, NULL);
>   	mutex_unlock(&pid_caches_mutex);
>   	/* current can fail, but someone else can succeed. */
>   	return READ_ONCE(*pkc);