Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1630370yba; Sat, 6 Apr 2019 18:31:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxx4qplPnbR5nu+c870Dali3nJ7oXWT+p5cis6GV3f11GgqREQ3kMGbD2yzuosMAXD+x2+d X-Received: by 2002:a65:6545:: with SMTP id a5mr9881581pgw.264.1554600661878; Sat, 06 Apr 2019 18:31:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554600661; cv=none; d=google.com; s=arc-20160816; b=MnWDmV9cL27aXvVHoQHZAPyabpr0EuyqyJJnjh81RxzT7mT15FhPUUiJi16peAsY4q rISsieNo4gLjQGXKvWEFF293sSKJV25lQYFVJ2/KrCEHBzXMJJ/Ls7bGBgP1aya8oOfm KAAZe2HH5xdA97JLotaz1r5MJ1gehTZUoNqyY4wGzzG9vIoWPtH+hwbnpzpH8cUlpJnx Bbkp0q5RdxiLdjo/QXjhh98ezh/dmDUWmsLvAGHHTBuXXPWLSJ3H/bBQTMSMHsk+ZMGO hi6gQQ6OpgEBa2wkJ7tCyNYTvC2j7cFiyXzoAcUZ8bnIcW1SIn5b0NnUZjpq8FE9cU5Q 0VCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=CkmdOJknXdcaGiP+P7T3IgyMmvRo7GHrO/eRbojkVUo=; b=WVO4uxgOtXIOtom5w3SRsBcsgh+E4WwoebR6EioPjFh23QGE2Qgzl93ZrrRTom7dYc ztFe6sQLLMg8Azd/gghKuBjYFuyoY8j8yH01wiw7xMja8lG3FVmGdW+072TVJD5TNhKG Oztr8gbLpfKC38LrIzLCHlOUr1+NjwYNDN6S0wu2vKueeetafq4GNk+EluIBo0WqS5f8 Cj+SxMAuKtvgbdqEHuLLWbmkAidnYqQzyjCtSAlomfe3RCqaNc5GAt9pnbdhfPxQT5lh ZgLJFDg1ZujwSgg6iR3Jh0BCYBChz6SdToss7/zGQ5a5nWVcWA8zddEzGpyXk8+ouQ/t fZfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 124si17577795pgi.38.2019.04.06.18.30.47; Sat, 06 Apr 2019 18:31:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbfDGB3h (ORCPT + 99 others); Sat, 6 Apr 2019 21:29:37 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39734 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfDGB3g (ORCPT ); Sat, 6 Apr 2019 21:29:36 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D236314BC08C2; Sat, 6 Apr 2019 18:29:35 -0700 (PDT) Date: Sat, 06 Apr 2019 18:29:35 -0700 (PDT) Message-Id: <20190406.182935.1539123668739096067.davem@davemloft.net> To: colin.king@canonical.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, liuyonglong@huawei.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: hns: fix unsigned comparison to less than zero From: David Miller In-Reply-To: <20190405135916.1621-1-colin.king@canonical.com> References: <20190405135916.1621-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 06 Apr 2019 18:29:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 5 Apr 2019 14:59:16 +0100 > From: Colin Ian King > > Currently mskid is unsigned and hence comparisons with negative > error return values are always false. Fix this by making mskid an > int. > > Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem") > Addresses-Coverity: ("Operands don't affect result") > Signed-off-by: Colin Ian King Applied.