Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1682593yba; Sat, 6 Apr 2019 20:24:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZZMK63dcx2hgkUwBGVLbHZuO3gwdT1DMxaCxLCOUfZ3/4eKEHW8r7w3IyG/qtq+w68Wh2 X-Received: by 2002:a63:ff26:: with SMTP id k38mr20844340pgi.123.1554607474508; Sat, 06 Apr 2019 20:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554607474; cv=none; d=google.com; s=arc-20160816; b=KsSIoZ8tPZHc/D1szO60StrO9siG7OMZuWgf4zjjrMKIgqTNl8m8RDfG0PLPvNsnwJ WvgzSK+JBVkfl+Tm68dwlucMlcdPagzMP4KXwyvn/hk/t7tWOvw1qcFX0TaPkVMaHW0V YnwXuCejnD3AGKPl3lwm4PafYaFeE+Gn8lmtLbTMHzMVrX3GsWukf4Sr47BbZLZpH7d3 JCFY0wN43Iz2KiioTW9diR6EPhAWy5a+Yq1v91SoFHGb+qN1Ub9zJ8KvrqKpPeLN9d9B WlYyDVLWVY53hfNnkj5kkeHKy9/ttaeXVPARzb7J0TYLr2k1iiT7HgK7BikN3KL2HNcz qzcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=w/h1PmdJZz1pdvYhXpwv57f7U5k5DhPqmyI5prsv5XY=; b=fZzg25lSrOESN6f3/TTRpubtWgBcKnnq9w6Rpm6YzfHLXInMk3L3s8ofX98rT2I3Z6 UNRqXbYArECrts8odUQ2YUxYevdiBnMcuGF/4BEdv5XJEy/e2ArWrt5ieu4BE8tXyAUJ XxyZuJ8yifPhzbHJqIPNQ6r1nAHAqPnPawipa8+eo1I2deJlop3LUO28c7Vi9Pqq1oBp GK9KXeswVXKIjO3bNhVMzJVsaxUCMotdz0Va5+8nZ6pCoSPi3ymkHUSkM17Q+5h8g/l7 d7FlZFGkNASZpfpGfWR2JdZxPCk6hHGROZtDbQyurv6SiH7Y2+modkNQj/re4l70XjU0 +WtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d186si23573465pfa.218.2019.04.06.20.24.18; Sat, 06 Apr 2019 20:24:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726456AbfDGDVI (ORCPT + 99 others); Sat, 6 Apr 2019 23:21:08 -0400 Received: from www.osadl.org ([62.245.132.105]:39362 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfDGDVH (ORCPT ); Sat, 6 Apr 2019 23:21:07 -0400 X-Greylist: delayed 3874 seconds by postgrey-1.27 at vger.kernel.org; Sat, 06 Apr 2019 23:21:06 EDT Received: from localhost.localdomain (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id x372GCs1021361; Sun, 7 Apr 2019 04:16:17 +0200 From: Nicholas Mc Guire To: Sakari Ailus Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 2/3] media: smiapp: regs: add range to usleep_range Date: Sun, 7 Apr 2019 04:16:03 +0200 Message-Id: <1554603364-10500-2-git-send-email-hofrat@opentech.at> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1554603364-10500-1-git-send-email-hofrat@opentech.at> References: <1554603364-10500-1-git-send-email-hofrat@opentech.at> X-Spam-Status: No, score=0.4 required=6.0 tests=BAYES_00,DATE_IN_FUTURE_96_Q, SPF_PASS autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As this is a retry loop for a sender not responding there is no reason to mandate a high accuracy delay - extend the sleep range to 2-4ms so that the hrtimer subsystem can work efficiently. Signed-off-by: Nicholas Mc Guire --- Problem located by an experimental coccinelle script Patch was compile tested with: x86_64_defconfig + MEDIA_SUPPORT=m, MEDIA_CAMERA_SUPPORT=y, MEDIA_CONTROLLER=y, VIDEO_V4L2_SUBDEV_API=y, VIDEO_SMIAPP=m Patch is against 5.1-rc3 (localversion-next is next-20190405) drivers/media/i2c/smiapp/smiapp-regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c b/drivers/media/i2c/smiapp/smiapp-regs.c index 145653d..dfa4f99 100644 --- a/drivers/media/i2c/smiapp/smiapp-regs.c +++ b/drivers/media/i2c/smiapp/smiapp-regs.c @@ -276,7 +276,7 @@ int smiapp_write_no_quirk(struct smiapp_sensor *sensor, u32 reg, u32 val) return 0; } - usleep_range(2000, 2000); + usleep_range(2000, 4000); } dev_err(&client->dev, -- 2.1.4