Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 7 Apr 2019 11:55:21 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Liu Xiang <liu.xiang6@zte.com.cn>
Cc:     linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        adilger.kernel@dilger.ca, liuxiang_1999@126.com
Subject: Re: [PATCH v2] ext4: fix prefetchw of NULL page
Message-ID: <20190407155521.GL18897@mit.edu>
Mail-Followup-To: Theodore Ts'o <tytso@mit.edu>,
        Liu Xiang <liu.xiang6@zte.com.cn>, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
        liuxiang_1999@126.com
References: <1554019894-11041-1-git-send-email-liu.xiang6@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1554019894-11041-1-git-send-email-liu.xiang6@zte.com.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 31, 2019 at 04:11:34PM +0800, Liu Xiang wrote:
> In ext4_mpage_readpages(), if the parameter pages is not NULL, another
> parameter page is NULL. At the first time prefetchw(&page->flags)
> works on NULL. From second time, prefetchw(&page->flags) always works on
> the last consumed page. This might do little improvment for handling
> current page. So prefetchw() should be called while the page pointer
> has just been updated.

Thanks, applied.

					- Ted