Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2453579yba; Sun, 7 Apr 2019 19:38:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxK3zy7FXz9JeBJBjY4cSHAsMlGbfJ/p9KEBQ7y4/FZXPOffhd+naF7/udNRsxLA6PDmXI X-Received: by 2002:a17:902:9a4a:: with SMTP id x10mr27890684plv.113.1554691093895; Sun, 07 Apr 2019 19:38:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554691093; cv=none; d=google.com; s=arc-20160816; b=Phz0y6igLkgwGHyBEk9DGlUO/89LjGGexifCESkgglzCarLVhtMzUHQ9R5eT35Caft C9o2L8XOfRrFmmbBSeGQwhKcQ1PSq6sCBLRluEhHzZXhoOmR1OMUv/tIreezgR7b5p11 /jxztvLZfwf9BdZdqjY3p+QKUj4r/Yfr202N3gYq/aSBF1dqiKWRp0J4qDjC8JRwlBsm 3+aq9xLvBMGGHEpahS1XGuh8LdHQgikcTCDpy3pD+5vaVn98oQSA8wZEUgEW8LEHN/a2 4tL/A79+gCkbMB9HMOxMq5TcLcDfJbQCd2uAUPEwgcMspXOjaCwhiujR6wsV9J+tDSkn LTHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Doy3wR5Iz41+h7JNUzAx/NC2cRNJseRKV9JMRjA0Di4=; b=0rajImVKDv8MwdPiplTAyrAi4iHKXOV2UVDkF6iNExFL8CUZ1cSdyFuhxyu2yQqLyP QLZhhuoDDZDQCJTEiOS1LGXXkdFEA+23znJ176E3qynK6ATC+Fo+lIxWqqbygkerveh5 uX6gOpRD5jFNKG6MKv+Vtaoa+db2fUotMdg5ZiLfA7oqgy1814i8ZX4LfWk17NL0PfHs edvvzxKCVwC51mOJL1RvukQ2FtITgL3UCNehQKYbkjNVtX81l/gTVzwXNh32JL0HsRYH UPpAdrO8QSaY8uZleRkd+TgqPkQir1doXB5mGJaEszB3eWmO5NALi13rVtu7NL5q+7fl Ww2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12si25069718pgc.157.2019.04.07.19.37.58; Sun, 07 Apr 2019 19:38:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfDHCgH (ORCPT + 99 others); Sun, 7 Apr 2019 22:36:07 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:33220 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfDHCgH (ORCPT ); Sun, 7 Apr 2019 22:36:07 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hDK8f-0005hW-Q6; Mon, 08 Apr 2019 10:36:01 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hDK8e-0003CE-0D; Mon, 08 Apr 2019 10:36:00 +0800 Date: Mon, 8 Apr 2019 10:35:59 +0800 From: Herbert Xu To: David Miller Cc: neilb@suse.com, tgraf@suug.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4 v2] Convert rhashtable to use bitlocks Message-ID: <20190408023559.d7h5cmijvakirdkg@gondor.apana.org.au> References: <155416000985.9540.14182958463813560577.stgit@noble.brown> <20190407.191255.1243683680105907349.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190407.191255.1243683680105907349.davem@davemloft.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 07, 2019 at 07:12:55PM -0700, David Miller wrote: > > This looks good to me and I haven't seen any major objections. > > I think however the thing is encoded, an unsigned long or a pointer, > the cleanliness is basically a wash. Hi Dave: The series as a whole definitely makes sense. Although I do think patch 3 can be improved slightly. But if you want to apply it now that's fine too as we can fix it up later. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt