Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190401073514.2785-1-jian-hong@endlessm.com> <alpine.DEB.2.21.1904052311370.1802@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1904052311370.1802@nanos.tec.linutronix.de>
From:   Jian-Hong Pan <jian-hong@endlessm.com>
Date:   Mon, 8 Apr 2019 14:02:14 +0800
Message-ID: <CAPpJ_edx2J6RyH2MuysXhE4hM61mWn+Th83HNeQtsFLF1K_mzA@mail.gmail.com>
Subject: Re: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux Upstreaming Team <linux@endlessm.com>,
        Daniel Drake <drake@endlessm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thomas Gleixner <tglx@linutronix.de> =E6=96=BC 2019=E5=B9=B44=E6=9C=886=E6=
=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=885:14=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, 1 Apr 2019, Jian-Hong Pan wrote:
> > +/*
> > + * Some machines require the "reboot=3De" commandline options
> > + */
> > +static int __init set_efi_reboot(const struct dmi_system_id *d)
> > +{
> > +     if (reboot_type !=3D BOOT_EFI) {
> > +             reboot_type =3D BOOT_EFI;
>
> So if EFI is disabled in the kernel this will fall through to BOOT_BIOS. =
Is
> that intended behaviour?

If not choose EFI as the reboot type, system will use APCI reboot type
on Acer TravelMate X514-51T.
If the reboot type is set as BIOS by appending "reboot=3Db", system
cannot reboot and hangs up when shutdown.

> > +             pr_info("%s series board detected. Selecting %s-method fo=
r reboot.\n",
> > +                     d->ident, "EFI");
>
> Is thee a reason not to write "EFI" in the string itself?

Just simply follow the format like functions: set_acpi_reboot, set_bios_reb=
oot
https://elixir.bootlin.com/linux/v5.1-rc4/source/arch/x86/kernel/reboot.c#L=
60

BR,
Jian-Hong Pan