Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jan Kotas <jank@cadence.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
CC:     Jan Kotas <jank@cadence.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "sanyog.r.kale@intel.com" <sanyog.r.kale@intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] soundwire: fix pm_runtime_get_sync return code checks
Thread-Topic: [PATCH] soundwire: fix pm_runtime_get_sync return code checks
Thread-Index: AQHU64EG18DSyeFoH06Vz3NnjCWS9aYtqsQAgAQy9AA=
Date:   Mon, 8 Apr 2019 07:12:03 +0000
Message-ID: <92538D7E-C628-40AC-AFE9-52C97B3BC42D@global.cadence.com>
References: <20190405072655.25995-1-jank@cadence.com>
 <367316fa-9d92-2dfc-32c4-3e0e8c76ef43@linux.intel.com>
In-Reply-To: <367316fa-9d92-2dfc-32c4-3e0e8c76ef43@linux.intel.com>
Accept-Language: en-US, pl-PL
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D0FA97D6FAC454499E72DEAB5204999D@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 56d19c66-bcfe-407b-ec1e-08d6bbf1803b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 07:12:03.0755
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2652
X-Proofpoint-SPF-Result: pass
X-Proofpoint-SPF-Record: v=spf1 include:_spf.salesforce.com include:mktomail.com
 include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com
 include:auth.msgapp.com include:spf.mandrillapp.com ~all
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-08_04:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1904080067
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On 5 Apr 2019, at 17:04, Pierre-Louis Bossart <pierre-louis.bossart@linux=
.intel.com> wrote:
>=20
> On 4/5/19 2:26 AM, Jan Kotas wrote:
>>=20
>> =20
>>  	ret =3D pm_runtime_get_sync(slave->bus->dev);
>> -	if (ret < 0)
>> +	if (ret < 0 && ret !=3D -EACCES)
>>=20
> There was a patch submitted on 3/28 by Srinivas Kandagatla who suggested =
an alternate solution for exactly the same code.
>=20
> +	if (pm_runtime_enabled(slave->bus->dev)) {
> +		ret =3D pm_runtime_get_sync(slave->bus->dev);
> +		if (ret < 0)
> +			return ret;
>=20
> I am far from an expert on pm_runtime but Srinivas' solution looks more e=
legant to me.

Hello Pierre,

Please take a look at this patch, that was my inspiration:
https://lists.linuxfoundation.org/pipermail/linux-pm/2011-June/031930.html

I also took a look, and it seems the value returned by=20
pm_runtime_get_syncis simply ignored in a lot of places,=20
so checking its value may be excessive.

Regards,
Jan=