Subject: [PATCH] RPA PCI Hotplug - redundant free
From: John Rose <johnrose@austin.ibm.com>
To: Greg KH <gregkh@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain
Message-Id: <1080765544.1889.13.camel@verve.austin.ibm.com>
Mime-Version: 1.0
Date: Wed, 31 Mar 2004 14:39:04 -0600
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 29

Hi Greg-

Apologies for the resend, messed up the lkml address.  Please commit the
following patch, which removes a redundant call to a
cleanup function from an error path of the module init code.

Thanks-
John

diff -Nru a/drivers/pci/hotplug/rpaphp_pci.c b/drivers/pci/hotplug/rpaphp_pci.c
--- a/drivers/pci/hotplug/rpaphp_pci.c	Tue Mar 30 18:50:32 2004
+++ b/drivers/pci/hotplug/rpaphp_pci.c	Tue Mar 30 18:50:32 2004
@@ -304,7 +304,6 @@
 	if (slot->hotplug_slot->info->adapter_status == NOT_VALID) {
 		dbg("%s: NOT_VALID: skip dn->full_name=%s\n",
 		    __FUNCTION__, slot->dn->full_name);
-		dealloc_slot_struct(slot);
 		return (-1);
 	}
 	return (0);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/